From 1ad565f4a1bb4fc25b94be1e6c76462f3f772d44 Mon Sep 17 00:00:00 2001 From: Matteo Concas Date: Mon, 19 Oct 2026 10:23:52 +0200 Subject: [PATCH] GPU Display: require GLFW >= 3.4 GPUDisplayFrontendGlfw.cxx uses glfwGetPlatform() and the GLFW_PLATFORM_* constants, introduced in GLFW 3.4. Without a minimum version the lookup accepted older system installs and the build failed at compile time instead of at configuration. Assisted by Claude Code --- GPU/GPUTracking/Standalone/CMakeLists.txt | 2 +- dependencies/FindGLFW.cmake | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/GPU/GPUTracking/Standalone/CMakeLists.txt b/GPU/GPUTracking/Standalone/CMakeLists.txt index ef02e1c819a0c..2d1bae68f480a 100644 --- a/GPU/GPUTracking/Standalone/CMakeLists.txt +++ b/GPU/GPUTracking/Standalone/CMakeLists.txt @@ -86,7 +86,7 @@ else() endif() if(GPUCA_BUILD_EVENT_DISPLAY) - find_package(GLFW NAMES glfw3 CONFIG REQUIRED) + find_package(GLFW 3.4 NAMES glfw3 CONFIG REQUIRED) find_package(GLEW REQUIRED) find_package(GLUT REQUIRED) find_package(OpenGL REQUIRED) diff --git a/dependencies/FindGLFW.cmake b/dependencies/FindGLFW.cmake index e062c6f06cec6..88357b153d1b7 100644 --- a/dependencies/FindGLFW.cmake +++ b/dependencies/FindGLFW.cmake @@ -9,9 +9,9 @@ # granted to it by virtue of its status as an Intergovernmental Organization # or submit itself to any jurisdiction. -# Simply provide a namespaced alias for the existing target +# Simply provide a namespaced alias for the existing target -find_package(GLFW NAMES glfw3 CONFIG) +find_package(GLFW 3.4 NAMES glfw3 CONFIG) if(NOT GLFW_FOUND) return() endif()