diff --git a/Common/Core/FFitWeights.cxx b/Common/Core/FFitWeights.cxx index f502b4bc3c4..30d4922d13c 100644 --- a/Common/Core/FFitWeights.cxx +++ b/Common/Core/FFitWeights.cxx @@ -86,8 +86,8 @@ void FFitWeights::init() fW_data->Add(new TProfile("pMeanPt", "", centBin, 0, centBin)); fW_data->Add(new TH2D("hPtWeight", "", centBin, 0, centBin, ptBin, ptAxis->GetXmin(), ptAxis->GetXmax())); - ptProfCent = reinterpret_cast(fW_data->FindObject("pMeanPt")); - h2ptCent = reinterpret_cast(fW_data->FindObject("hPtWeight")); + ptProfCent = dynamic_cast(fW_data->FindObject("pMeanPt")); + h2ptCent = dynamic_cast(fW_data->FindObject("hPtWeight")); }; void FFitWeights::fillWeights(float centrality, float qn, int nh, const char* pf) @@ -98,10 +98,10 @@ void FFitWeights::fillWeights(float centrality, float qn, int nh, const char* pf if (!tar) return; - TH2D* th2 = reinterpret_cast(tar->FindObject(this->getQName(nh, pf))); + TH2D* th2 = dynamic_cast(tar->FindObject(this->getQName(nh, pf))); if (!th2) { tar->Add(new TH2D(this->getQName(nh, pf), this->getAxisName(nh, pf), centBin, 0, centBin, qAxis->GetNbins(), qAxis->GetXmin(), qAxis->GetXmax())); - th2 = reinterpret_cast(tar->At(tar->GetEntries() - 1)); + th2 = dynamic_cast(tar->At(tar->GetEntries() - 1)); } th2->Fill(centrality, qn); }; @@ -117,7 +117,7 @@ void FFitWeights::fillPt(float centrality, float pt, float weight, bool first) float FFitWeights::getPtMult(float centrality) { if (!ptProfCent) { - ptProfCent = reinterpret_cast(fW_data->FindObject("pMeanPt")); + ptProfCent = dynamic_cast(fW_data->FindObject("pMeanPt")); } return ptProfCent->GetBinContent(ptProfCent->FindBin(centrality)); }; @@ -132,7 +132,7 @@ Long64_t FFitWeights::Merge(TCollection* collist) } FFitWeights* lW = 0; TIter allW(collist); - while ((lW = (reinterpret_cast(allW())))) { + while ((lW = (dynamic_cast(allW())))) { addArray(fW_data, lW->getDataArray()); nmerged++; } @@ -150,7 +150,7 @@ void FFitWeights::addArray(TObjArray* targ, TObjArray* sour) auto* tObj = targ->FindObject(obj->GetName()); if (!tObj) { - auto* clone = static_cast(obj->Clone(obj->GetName())); + auto* clone = obj->Clone(obj->GetName()); if (auto* h = dynamic_cast(clone)) h->SetDirectory(0); targ->Add(clone); @@ -168,7 +168,7 @@ void FFitWeights::mptSel() if (!tar) return; - TH2D* th2 = reinterpret_cast(tar->FindObject("hPtWeight")); + TH2D* th2 = dynamic_cast(tar->FindObject("hPtWeight")); if (!th2) { return; } @@ -198,7 +198,7 @@ void FFitWeights::qSelection(const std::vector& nhv, const std::vector(tar->FindObject(this->getQName(nh, pf.c_str())))}; + TH2D* th2{dynamic_cast(tar->FindObject(this->getQName(nh, pf.c_str())))}; if (!th2) { LOGF(info, "FFitWeights qh not found!"); return; diff --git a/Common/Core/PID/PIDTOFParamService.cxx b/Common/Core/PID/PIDTOFParamService.cxx index efd840273fa..e8138e21e28 100644 --- a/Common/Core/PID/PIDTOFParamService.cxx +++ b/Common/Core/PID/PIDTOFParamService.cxx @@ -298,7 +298,7 @@ struct TOFSupport : o2::framework::ServicePlugin { }, .configure = CommonServices::noConfiguration(), .exit = [](ServiceRegistryRef, void* service) { - auto* resp = reinterpret_cast(service); + auto* resp = static_cast(service); delete resp; }, .kind = ServiceKind::Serial}; } diff --git a/Common/Core/Zorro.cxx b/Common/Core/Zorro.cxx index 6eb0b61c118..f110b8a9a85 100644 --- a/Common/Core/Zorro.cxx +++ b/Common/Core/Zorro.cxx @@ -72,7 +72,7 @@ void Zorro::populateHistRegistry(o2::framework::HistogramRegistry& histRegistry, for (int iBin{2}; iBin < mSelections->GetNbinsX(); ++iBin) { // Exclude first and last bins as they are total number of analysed and selected events, respectively mAnalysedTriggers->GetXaxis()->SetBinLabel(iBin - 1, mSelections->GetXaxis()->GetBinLabel(iBin)); } - std::shared_ptr selections = histRegistry.add((folderName + "/" + std::to_string(runNumber) + "/" + "Selections").data(), "", o2::framework::HistType::kTH1D, {{mSelections->GetNbinsX(), -0.5, static_cast(mSelections->GetNbinsX() - 0.5)}}); + std::shared_ptr selections = histRegistry.add((folderName + "/" + std::to_string(runNumber) + "/" + "Selections").data(), "", o2::framework::HistType::kTH1D, {{mSelections->GetNbinsX(), -0.5, (mSelections->GetNbinsX() - 0.5)}}); selections->SetBit(TH1::kIsAverage); for (int iBin{1}; iBin <= mSelections->GetNbinsX(); ++iBin) { selections->GetXaxis()->SetBinLabel(iBin, mSelections->GetXaxis()->GetBinLabel(iBin)); @@ -81,7 +81,7 @@ void Zorro::populateHistRegistry(o2::framework::HistogramRegistry& histRegistry, } } if (mScalers) { - std::shared_ptr scalers = histRegistry.add((folderName + "/" + std::to_string(runNumber) + "/" + "Scalers").data(), "", o2::framework::HistType::kTH1D, {{mScalers->GetNbinsX(), -0.5, static_cast(mScalers->GetNbinsX() - 0.5)}}); + std::shared_ptr scalers = histRegistry.add((folderName + "/" + std::to_string(runNumber) + "/" + "Scalers").data(), "", o2::framework::HistType::kTH1D, {{mScalers->GetNbinsX(), -0.5, (mScalers->GetNbinsX() - 0.5)}}); scalers->SetBit(TH1::kIsAverage); for (int iBin{1}; iBin <= mScalers->GetNbinsX(); ++iBin) { scalers->GetXaxis()->SetBinLabel(iBin, mScalers->GetXaxis()->GetBinLabel(iBin)); @@ -90,7 +90,7 @@ void Zorro::populateHistRegistry(o2::framework::HistogramRegistry& histRegistry, } } if (mInspectedTVX) { - std::shared_ptr inspectedTVX = histRegistry.add((folderName + "/" + std::to_string(runNumber) + "/" + "InspectedTVX").data(), "", o2::framework::HistType::kTH1D, {{mInspectedTVX->GetNbinsX(), -0.5, static_cast(mInspectedTVX->GetNbinsX() - 0.5)}}); + std::shared_ptr inspectedTVX = histRegistry.add((folderName + "/" + std::to_string(runNumber) + "/" + "InspectedTVX").data(), "", o2::framework::HistType::kTH1D, {{mInspectedTVX->GetNbinsX(), -0.5, (mInspectedTVX->GetNbinsX() - 0.5)}}); inspectedTVX->SetBit(TH1::kIsAverage); for (int iBin{1}; iBin <= mInspectedTVX->GetNbinsX(); ++iBin) { inspectedTVX->GetXaxis()->SetBinLabel(iBin, mInspectedTVX->GetXaxis()->GetBinLabel(iBin)); @@ -99,7 +99,7 @@ void Zorro::populateHistRegistry(o2::framework::HistogramRegistry& histRegistry, } } if (mTOIs.size()) { - mAnalysedTriggersOfInterest = histRegistry.add((folderName + "/" + std::to_string(runNumber) + "/" + "AnalysedTriggersOfInterest").data(), "", o2::framework::HistType::kTH1D, {{static_cast(mTOIs.size()), -0.5, static_cast(mTOIs.size() - 0.5)}}).get(); + mAnalysedTriggersOfInterest = histRegistry.add((folderName + "/" + std::to_string(runNumber) + "/" + "AnalysedTriggersOfInterest").data(), "", o2::framework::HistType::kTH1D, {{static_cast(mTOIs.size()), -0.5, (mTOIs.size() - 0.5)}}).get(); for (size_t i{0}; i < mTOIs.size(); ++i) { mAnalysedTriggersOfInterest->GetXaxis()->SetBinLabel(i + 1, mTOIs[i].data()); } diff --git a/Common/Core/ZorroSummary.cxx b/Common/Core/ZorroSummary.cxx index 0a1012c3edc..bb020dc0924 100644 --- a/Common/Core/ZorroSummary.cxx +++ b/Common/Core/ZorroSummary.cxx @@ -20,7 +20,7 @@ void ZorroSummary::Copy(TObject& c) const { - static_cast(c) = *this; + dynamic_cast(c) = *this; } Long64_t ZorroSummary::Merge(TCollection* list) diff --git a/Common/Core/macros/testMetadataHelper.C b/Common/Core/macros/testMetadataHelper.C index dd20cba9c44..12b29935455 100644 --- a/Common/Core/macros/testMetadataHelper.C +++ b/Common/Core/macros/testMetadataHelper.C @@ -45,7 +45,7 @@ auto readMetadata(std::unique_ptr& currentFile) -> std::vector { // Get the metadata, if any - auto m = (TMap*)currentFile->Get("metaData"); + auto m = dynamic_cast(currentFile->Get("metaData")); if (!m) { return {}; } @@ -59,7 +59,7 @@ auto readMetadata(std::unique_ptr& currentFile) -> std::vectorGetName()); first = false; } - auto objString = (TObjString*)m->GetValue(obj); + auto objString = dynamic_cast(m->GetValue(obj)); std::string key = "aod-metadata-" + std::string(obj->GetName()); LOGP(info, "- {}: {} goes into key {}", obj->GetName(), objString->String().Data(), key); char const* value = strdup(objString->String()); diff --git a/Common/TableProducer/PID/pidTOFBase.cxx b/Common/TableProducer/PID/pidTOFBase.cxx index 2ef09079f5e..257dbf5b6b9 100644 --- a/Common/TableProducer/PID/pidTOFBase.cxx +++ b/Common/TableProducer/PID/pidTOFBase.cxx @@ -376,7 +376,7 @@ struct tofEventTime { tableFlags(0); tableEvTime(0.f, 999.f); if (enableTableTOFOnly) { - tableEvTimeTOFOnly((uint8_t)0, 0.f, 0.f, -1); + tableEvTimeTOFOnly(static_cast(0), 0.f, 0.f, -1); } continue; } @@ -408,7 +408,7 @@ struct tofEventTime { tableFlags(flags); tableEvTime(et, erret); if (enableTableTOFOnly) { - tableEvTimeTOFOnly((uint8_t)filterForTOFEventTime(trk), et, erret, evTimeTOF.mEventTimeMultiplicity); + tableEvTimeTOFOnly(static_cast(filterForTOFEventTime(trk)), et, erret, evTimeTOF.mEventTimeMultiplicity); } } } @@ -438,7 +438,7 @@ struct tofEventTime { tableFlags(0); tableEvTime(0.f, 999.f); if (enableTableTOFOnly) { - tableEvTimeTOFOnly((uint8_t)0, 0.f, 0.f, -1); + tableEvTimeTOFOnly(static_cast(0), 0.f, 0.f, -1); } continue; } @@ -504,7 +504,7 @@ struct tofEventTime { } tableEvTime(eventTime / sumOfWeights, std::sqrt(1. / sumOfWeights)); if (enableTableTOFOnly) { - tableEvTimeTOFOnly((uint8_t)filterForTOFEventTime(trk), t0TOF[0], t0TOF[1], evTimeTOF.mEventTimeMultiplicity); + tableEvTimeTOFOnly(static_cast(filterForTOFEventTime(trk)), t0TOF[0], t0TOF[1], evTimeTOF.mEventTimeMultiplicity); } } } @@ -529,7 +529,7 @@ struct tofEventTime { for (auto const& t : tracks) { // Loop on collisions if (enableTableTOFOnly) { - tableEvTimeTOFOnly((uint8_t)0, 0.f, 0.f, -1); + tableEvTimeTOFOnly(static_cast(0), 0.f, 0.f, -1); } if (!t.has_collision() || collisions.size() == 0) { // Track was not assigned, cannot compute event time tableFlags(0); diff --git a/Common/TableProducer/PID/pidTOFMerge.cxx b/Common/TableProducer/PID/pidTOFMerge.cxx index f5ec6e68a6f..8b1486f94d2 100644 --- a/Common/TableProducer/PID/pidTOFMerge.cxx +++ b/Common/TableProducer/PID/pidTOFMerge.cxx @@ -405,7 +405,7 @@ struct tofEventTime { tableFlags(0); tableEvTime(0.f, 999.f); if (enableTableEvTimeTOFOnly) { - tableEvTimeTOFOnly((uint8_t)0, 0.f, 0.f, -1); + tableEvTimeTOFOnly(static_cast(0), 0.f, 0.f, -1); } continue; } @@ -470,7 +470,7 @@ struct tofEventTime { } tableEvTime(eventTime / sumOfWeights, std::sqrt(1. / sumOfWeights)); if (enableTableEvTimeTOFOnly) { - tableEvTimeTOFOnly((uint8_t)filterForTOFEventTime(trk), t0TOF[0], t0TOF[1], evTimeMakerTOF.mEventTimeMultiplicity); + tableEvTimeTOFOnly(static_cast(filterForTOFEventTime(trk)), t0TOF[0], t0TOF[1], evTimeMakerTOF.mEventTimeMultiplicity); } } } @@ -481,7 +481,7 @@ struct tofEventTime { tableFlags(0); tableEvTime(0.f, 999.f); if (enableTableEvTimeTOFOnly) { - tableEvTimeTOFOnly((uint8_t)0, 0.f, 0.f, -1); + tableEvTimeTOFOnly(static_cast(0), 0.f, 0.f, -1); } continue; } @@ -513,14 +513,14 @@ struct tofEventTime { tableFlags(flags); tableEvTime(et, erret); if (enableTableEvTimeTOFOnly) { - tableEvTimeTOFOnly((uint8_t)filterForTOFEventTime(trk), et, erret, evTimeMakerTOF.mEventTimeMultiplicity); + tableEvTimeTOFOnly(static_cast(filterForTOFEventTime(trk)), et, erret, evTimeMakerTOF.mEventTimeMultiplicity); } } } } else if (mComputeEvTimeWithTOF == 0 && mComputeEvTimeWithFT0 == 1) { for (auto const& t : tracks) { // Loop on collisions if (enableTableEvTimeTOFOnly) { - tableEvTimeTOFOnly((uint8_t)0, 0.f, 0.f, -1); + tableEvTimeTOFOnly(static_cast(0), 0.f, 0.f, -1); } if (!t.has_collision() || collisions.size() == 0) { // Track was not assigned, cannot compute event time tableFlags(0); diff --git a/Common/TableProducer/PID/pidTPCBase.cxx b/Common/TableProducer/PID/pidTPCBase.cxx index 1a86f0f70ec..422a6d7c435 100644 --- a/Common/TableProducer/PID/pidTPCBase.cxx +++ b/Common/TableProducer/PID/pidTPCBase.cxx @@ -61,7 +61,7 @@ struct PidMultiplicity { } using TrksIU = soa::Join; - Partition tracksWithTPCIU = (aod::track::tpcNClsFindable > (uint8_t)0); + Partition tracksWithTPCIU = (aod::track::tpcNClsFindable > static_cast(0)); void processIU(aod::Collision const& collision, TrksIU const&) { if (!enableTable) { @@ -73,7 +73,7 @@ struct PidMultiplicity { PROCESS_SWITCH(PidMultiplicity, processIU, "Process with IU tracks, faster but works on Run3 only", false); using Trks = soa::Join; - Partition tracksWithTPC = (aod::track::tpcNClsFindable > (uint8_t)0); + Partition tracksWithTPC = (aod::track::tpcNClsFindable > static_cast(0)); void processStandard(aod::Collision const& collision, Trks const&) { if (!enableTable) { diff --git a/Common/TableProducer/match-mft-ft0.cxx b/Common/TableProducer/match-mft-ft0.cxx index 43d43ebab84..d282c75c6fe 100644 --- a/Common/TableProducer/match-mft-ft0.cxx +++ b/Common/TableProducer/match-mft-ft0.cxx @@ -147,8 +147,8 @@ T getCompatibleBCs(aod::MFTTracks::iterator const& track, aod::Collision const& int64_t minBCId = bcIt.globalIndex(); - if ((int64_t)bcIt.globalBC() < firstBC + deltaBC) { - while (bcIt != bcs.end() && (int64_t)bcIt.globalBC() < firstBC + deltaBC) { + if (static_cast(bcIt.globalBC()) < firstBC + deltaBC) { + while (bcIt != bcs.end() && static_cast(bcIt.globalBC()) < firstBC + deltaBC) { minBCId = bcIt.globalIndex(); ++bcIt; @@ -163,11 +163,11 @@ T getCompatibleBCs(aod::MFTTracks::iterator const& track, aod::Collision const& } else { // here bcIt.globalBC() >= firstBC + deltaBC - while (bcIt != bcs.begin() && (int64_t)bcIt.globalBC() >= (int64_t)firstBC + deltaBC) { + while (bcIt != bcs.begin() && static_cast(bcIt.globalBC()) >= firstBC + deltaBC) { minBCId = bcIt.globalIndex(); --bcIt; } - if (bcIt == bcs.begin() && (int64_t)bcIt.globalBC() >= (int64_t)firstBC + deltaBC) { + if (bcIt == bcs.begin() && static_cast(bcIt.globalBC()) >= firstBC + deltaBC) { minBCId = bcIt.globalIndex(); } ++bcIt; // retrieve the pointer which gave minBCId and minGlobalBC @@ -178,12 +178,12 @@ T getCompatibleBCs(aod::MFTTracks::iterator const& track, aod::Collision const& int64_t maxBCId = bcIt.globalIndex(); - if ((int64_t)bcIt.globalBC() > (int64_t)lastBC + deltaBC) { + if (static_cast(bcIt.globalBC()) > lastBC + deltaBC) { // the previous minimum is actually bigger than the right boundary if (bcIt != bcs.begin()) { - --bcIt; // let's check the previous element in the BC list - if ((int64_t)bcIt.globalBC() < (int64_t)firstBC + deltaBC) // if this previous element is smaller than the left boundary + --bcIt; // let's check the previous element in the BC list + if (static_cast(bcIt.globalBC()) < firstBC + deltaBC) // if this previous element is smaller than the left boundary { // means that the slice of compatible BCs is empty @@ -192,18 +192,18 @@ T getCompatibleBCs(aod::MFTTracks::iterator const& track, aod::Collision const& } } - if ((int64_t)bcIt.globalBC() < (int64_t)firstBC + deltaBC) { + if (static_cast(bcIt.globalBC()) < firstBC + deltaBC) { // the previous minimum is actually smaller than the right boundary ++bcIt; - if (bcIt != bcs.end() && ((int64_t)bcIt.globalBC() > (int64_t)lastBC + deltaBC)) { + if (bcIt != bcs.end() && (static_cast(bcIt.globalBC()) > lastBC + deltaBC)) { // check the following element return bcs.emptySlice(); } } - while (bcIt != bcs.end() && (int64_t)bcIt.globalBC() <= (int64_t)lastBC + deltaBC) { + while (bcIt != bcs.end() && static_cast(bcIt.globalBC()) <= lastBC + deltaBC) { maxBCId = bcIt.globalIndex(); ++bcIt; @@ -275,7 +275,7 @@ struct matchmftft0 { o2::base::Propagator::initFieldFromGRP(grpmag); // for some reason this is necessary for the next next line runNumber = bc.runNumber(); - o2::field::MagneticField* field = static_cast(TGeoGlobalMagField::Instance()->GetField()); + o2::field::MagneticField* field = dynamic_cast(TGeoGlobalMagField::Instance()->GetField()); Bz = field->getBz(centerMFT); // gives error if the propagator is not initFielded LOG(info) << "The field at the center of the MFT is Bz = " << Bz; diff --git a/Common/TableProducer/match-mft-mch-data-mc.cxx b/Common/TableProducer/match-mft-mch-data-mc.cxx index 7b3be6fa633..df7a0846fd9 100644 --- a/Common/TableProducer/match-mft-mch-data-mc.cxx +++ b/Common/TableProducer/match-mft-mch-data-mc.cxx @@ -643,7 +643,7 @@ struct match_mft_mch_data_mc { ccdbManager->get(geoPath); } o2::mch::TrackExtrap::setField(); - fieldB = static_cast(TGeoGlobalMagField::Instance()->GetField()); + fieldB = dynamic_cast(TGeoGlobalMagField::Instance()->GetField()); } void init(o2::framework::InitContext&) @@ -703,7 +703,7 @@ struct match_mft_mch_data_mc { tableMatchingParams(matching.getGMPtAtDCA(), matching.getGMEtaAtDCA(), - static_cast(matching.getGMQ()), + matching.getGMQ(), matching.getDpt(), matching.getDx(), matching.getDy(), @@ -732,7 +732,7 @@ struct match_mft_mch_data_mc { tableMixMatchingParams(matching.getGMPtAtDCA(), matching.getGMEtaAtDCA(), - static_cast(matching.getGMQ()), + matching.getGMQ(), matching.getDpt(), matching.getDx(), matching.getDy(), diff --git a/Common/TableProducer/match-mft-mch-data.cxx b/Common/TableProducer/match-mft-mch-data.cxx index 4a6b9be135e..c001315b2cd 100644 --- a/Common/TableProducer/match-mft-mch-data.cxx +++ b/Common/TableProducer/match-mft-mch-data.cxx @@ -643,7 +643,7 @@ struct match_mft_mch_data_mc { ccdbManager->get(geoPath); } o2::mch::TrackExtrap::setField(); - fieldB = static_cast(TGeoGlobalMagField::Instance()->GetField()); + fieldB = dynamic_cast(TGeoGlobalMagField::Instance()->GetField()); } void init(o2::framework::InitContext&) @@ -703,7 +703,7 @@ struct match_mft_mch_data_mc { tableMatchingParams(matching.getGMPtAtDCA(), matching.getGMEtaAtDCA(), - static_cast(matching.getGMQ()), + matching.getGMQ(), matching.getDpt(), matching.getDx(), matching.getDy(), @@ -732,7 +732,7 @@ struct match_mft_mch_data_mc { tableMixMatchingParams(matching.getGMPtAtDCA(), matching.getGMEtaAtDCA(), - static_cast(matching.getGMQ()), + matching.getGMQ(), matching.getDpt(), matching.getDx(), matching.getDy(), diff --git a/Common/TableProducer/muonRealignment.cxx b/Common/TableProducer/muonRealignment.cxx index 5b1a597a73c..b0585f8ba9f 100644 --- a/Common/TableProducer/muonRealignment.cxx +++ b/Common/TableProducer/muonRealignment.cxx @@ -289,16 +289,16 @@ struct MuonRealignment { fwdTrkCovRealignInfo.sigPhi = TMath::Sqrt(fwdtrack.getCovariances()(2, 2)); fwdTrkCovRealignInfo.sigTgl = TMath::Sqrt(fwdtrack.getCovariances()(3, 3)); fwdTrkCovRealignInfo.sig1Pt = TMath::Sqrt(fwdtrack.getCovariances()(4, 4)); - fwdTrkCovRealignInfo.rhoXY = (Char_t)(128. * fwdtrack.getCovariances()(0, 1) / (fwdTrkCovRealignInfo.sigX * fwdTrkCovRealignInfo.sigY)); - fwdTrkCovRealignInfo.rhoPhiX = (Char_t)(128. * fwdtrack.getCovariances()(0, 2) / (fwdTrkCovRealignInfo.sigPhi * fwdTrkCovRealignInfo.sigX)); - fwdTrkCovRealignInfo.rhoPhiY = (Char_t)(128. * fwdtrack.getCovariances()(1, 2) / (fwdTrkCovRealignInfo.sigPhi * fwdTrkCovRealignInfo.sigY)); - fwdTrkCovRealignInfo.rhoTglX = (Char_t)(128. * fwdtrack.getCovariances()(0, 3) / (fwdTrkCovRealignInfo.sigTgl * fwdTrkCovRealignInfo.sigX)); - fwdTrkCovRealignInfo.rhoTglY = (Char_t)(128. * fwdtrack.getCovariances()(1, 3) / (fwdTrkCovRealignInfo.sigTgl * fwdTrkCovRealignInfo.sigY)); - fwdTrkCovRealignInfo.rhoTglPhi = (Char_t)(128. * fwdtrack.getCovariances()(2, 3) / (fwdTrkCovRealignInfo.sigTgl * fwdTrkCovRealignInfo.sigPhi)); - fwdTrkCovRealignInfo.rho1PtX = (Char_t)(128. * fwdtrack.getCovariances()(0, 4) / (fwdTrkCovRealignInfo.sig1Pt * fwdTrkCovRealignInfo.sigX)); - fwdTrkCovRealignInfo.rho1PtY = (Char_t)(128. * fwdtrack.getCovariances()(1, 4) / (fwdTrkCovRealignInfo.sig1Pt * fwdTrkCovRealignInfo.sigY)); - fwdTrkCovRealignInfo.rho1PtPhi = (Char_t)(128. * fwdtrack.getCovariances()(2, 4) / (fwdTrkCovRealignInfo.sig1Pt * fwdTrkCovRealignInfo.sigPhi)); - fwdTrkCovRealignInfo.rho1PtTgl = (Char_t)(128. * fwdtrack.getCovariances()(3, 4) / (fwdTrkCovRealignInfo.sig1Pt * fwdTrkCovRealignInfo.sigTgl)); + fwdTrkCovRealignInfo.rhoXY = static_cast(128. * fwdtrack.getCovariances()(0, 1) / (fwdTrkCovRealignInfo.sigX * fwdTrkCovRealignInfo.sigY)); + fwdTrkCovRealignInfo.rhoPhiX = static_cast(128. * fwdtrack.getCovariances()(0, 2) / (fwdTrkCovRealignInfo.sigPhi * fwdTrkCovRealignInfo.sigX)); + fwdTrkCovRealignInfo.rhoPhiY = static_cast(128. * fwdtrack.getCovariances()(1, 2) / (fwdTrkCovRealignInfo.sigPhi * fwdTrkCovRealignInfo.sigY)); + fwdTrkCovRealignInfo.rhoTglX = static_cast(128. * fwdtrack.getCovariances()(0, 3) / (fwdTrkCovRealignInfo.sigTgl * fwdTrkCovRealignInfo.sigX)); + fwdTrkCovRealignInfo.rhoTglY = static_cast(128. * fwdtrack.getCovariances()(1, 3) / (fwdTrkCovRealignInfo.sigTgl * fwdTrkCovRealignInfo.sigY)); + fwdTrkCovRealignInfo.rhoTglPhi = static_cast(128. * fwdtrack.getCovariances()(2, 3) / (fwdTrkCovRealignInfo.sigTgl * fwdTrkCovRealignInfo.sigPhi)); + fwdTrkCovRealignInfo.rho1PtX = static_cast(128. * fwdtrack.getCovariances()(0, 4) / (fwdTrkCovRealignInfo.sig1Pt * fwdTrkCovRealignInfo.sigX)); + fwdTrkCovRealignInfo.rho1PtY = static_cast(128. * fwdtrack.getCovariances()(1, 4) / (fwdTrkCovRealignInfo.sig1Pt * fwdTrkCovRealignInfo.sigY)); + fwdTrkCovRealignInfo.rho1PtPhi = static_cast(128. * fwdtrack.getCovariances()(2, 4) / (fwdTrkCovRealignInfo.sig1Pt * fwdTrkCovRealignInfo.sigPhi)); + fwdTrkCovRealignInfo.rho1PtTgl = static_cast(128. * fwdtrack.getCovariances()(3, 4) / (fwdTrkCovRealignInfo.sig1Pt * fwdTrkCovRealignInfo.sigTgl)); LOGF(debug, "TrackParm %d, x:%g y:%g z:%g phi:%g tgl:%g InvQPt:%g chi2:%g nClusters:%d", muon.globalIndex(), muon.x(), muon.y(), muon.z(), muon.phi(), muon.tgl(), muon.signed1Pt(), muon.chi2(), muon.nClusters()); LOGF(debug, "Re-aligned trackParm %d, x:%g y:%g z:%g phi:%g tgl:%g InvQPt:%g chi2:%g nClusters:%d removable:%d", muonRealignId, fwdtrack.getX(), fwdtrack.getY(), fwdtrack.getZ(), fwdtrack.getPhi(), fwdtrack.getTgl(), fwdtrack.getInvQPt(), fwdtrack.getTrackChi2(), convertedTrack.getNClusters(), removable); // Fill refitted track info diff --git a/Common/TableProducer/trackselection.cxx b/Common/TableProducer/trackselection.cxx index e8619bd9ccb..4cd90b0c1c7 100644 --- a/Common/TableProducer/trackselection.cxx +++ b/Common/TableProducer/trackselection.cxx @@ -160,7 +160,7 @@ struct TrackSelectionTask { const o2::aod::track::TrackSelectionFlags::flagtype trackflagGlob = globalTracks.IsSelectedMask(track); if (produceTable == 1) { - filterTable((uint8_t)0, + filterTable(static_cast(0), trackflagGlob, filtBit1.IsSelected(track), filtBit2.IsSelected(track), @@ -200,7 +200,7 @@ struct TrackSelectionTask { for (const auto& track : tracks) { o2::aod::track::TrackSelectionFlags::flagtype trackflagGlob = globalTracks.IsSelectedMask(track); if (produceTable == 1) { - filterTable((uint8_t)globalTracksSDD.IsSelected(track), + filterTable(static_cast(globalTracksSDD.IsSelected(track)), trackflagGlob, filtBit1.IsSelected(track), filtBit2.IsSelected(track), diff --git a/Common/TableProducer/zdcTaskLightIons.cxx b/Common/TableProducer/zdcTaskLightIons.cxx index 1cc5c7826d4..7681551328c 100644 --- a/Common/TableProducer/zdcTaskLightIons.cxx +++ b/Common/TableProducer/zdcTaskLightIons.cxx @@ -128,50 +128,50 @@ struct ZdcTaskLightIons { selected = std::fabs(collision.posZ()) < cfgEvSelVtxZ; if (selected) { - selectionBits |= (uint8_t)(0x1u << evSel_zvtx); + selectionBits |= static_cast(0x1u << evSel_zvtx); registry.fill(HIST("hEventCount"), evSel_zvtx); } selected = collision.sel8(); if (selected) { - selectionBits |= (uint8_t)(0x1u << evSel_sel8); + selectionBits |= static_cast(0x1u << evSel_sel8); registry.fill(HIST("hEventCount"), evSel_sel8); } auto occupancy = collision.trackOccupancyInTimeRange(); selected = occupancy <= cfgEvSelsMaxOccupancy; if (selected) { - selectionBits |= (uint8_t)(0x1u << evSel_occupancy); + selectionBits |= static_cast(0x1u << evSel_occupancy); registry.fill(HIST("hEventCount"), evSel_occupancy); } selected = collision.selection_bit(o2::aod::evsel::kNoSameBunchPileup); if (selected) { - selectionBits |= (uint8_t)(0x1u << evSel_kNoSameBunchPileup); + selectionBits |= static_cast(0x1u << evSel_kNoSameBunchPileup); registry.fill(HIST("hEventCount"), evSel_kNoSameBunchPileup); } selected = collision.selection_bit(o2::aod::evsel::kIsGoodZvtxFT0vsPV); if (selected) { - selectionBits |= (uint8_t)(0x1u << evSel_kIsGoodZvtxFT0vsPV); + selectionBits |= static_cast(0x1u << evSel_kIsGoodZvtxFT0vsPV); registry.fill(HIST("hEventCount"), evSel_kIsGoodZvtxFT0vsPV); } selected = collision.selection_bit(o2::aod::evsel::kNoCollInTimeRangeStandard); if (selected) { - selectionBits |= (uint8_t)(0x1u << evSel_kNoCollInTimeRangeStandard); + selectionBits |= static_cast(0x1u << evSel_kNoCollInTimeRangeStandard); registry.fill(HIST("hEventCount"), evSel_kNoCollInTimeRangeStandard); } selected = collision.selection_bit(o2::aod::evsel::kNoITSROFrameBorder); if (selected) { - selectionBits |= (uint8_t)(0x1u << evSel_kNoITSROFrameBorder); + selectionBits |= static_cast(0x1u << evSel_kNoITSROFrameBorder); registry.fill(HIST("hEventCount"), evSel_kNoITSROFrameBorder); } selected = collision.selection_bit(o2::aod::evsel::kIsGoodITSLayersAll); if (selected) { - selectionBits |= (uint8_t)(0x1u << evSel_kIsGoodITSLayersAll); + selectionBits |= static_cast(0x1u << evSel_kIsGoodITSLayersAll); registry.fill(HIST("hEventCount"), evSel_kIsGoodITSLayersAll); } @@ -208,16 +208,16 @@ struct ZdcTaskLightIons { uint8_t maskSel = 0; if (bcPatternB[bcInOrbit]) { - maskSel |= (uint8_t)(0x1u << bcMask_beamB); + maskSel |= static_cast(0x1u << bcMask_beamB); } if (bcPatternA[bcInOrbit]) { - maskSel |= (uint8_t)(0x1u << bcMask_beamA); + maskSel |= static_cast(0x1u << bcMask_beamA); } if (bcPatternC[bcInOrbit]) { - maskSel |= (uint8_t)(0x1u << bcMask_beamC); + maskSel |= static_cast(0x1u << bcMask_beamC); } if (bcPatternE[bcInOrbit]) { - maskSel |= (uint8_t)(0x1u << bcMask_beamE); + maskSel |= static_cast(0x1u << bcMask_beamE); } auto tdcZNA = bc.zdc().timeZNA(); diff --git a/Common/Tasks/checkDataModelMC.cxx b/Common/Tasks/checkDataModelMC.cxx index 8eb6efc03f2..105ada03c72 100644 --- a/Common/Tasks/checkDataModelMC.cxx +++ b/Common/Tasks/checkDataModelMC.cxx @@ -57,7 +57,7 @@ void checkDaughters(const T& particlesMC, } } for (const auto& idxDau : particle.daughtersIds()) { - if (idxDau >= 0 && ((uint64_t)idxDau > offset + particlesMC.size() || (uint64_t)idxDau < offset)) { + if (idxDau >= 0 && (static_cast(idxDau) > offset + particlesMC.size() || static_cast(idxDau) < offset)) { if (debugMode) { debugHisto->Fill(1); } else { diff --git a/Common/Tasks/multiplicityQa.cxx b/Common/Tasks/multiplicityQa.cxx index 3c8c1100af8..6a6c09188cf 100644 --- a/Common/Tasks/multiplicityQa.cxx +++ b/Common/Tasks/multiplicityQa.cxx @@ -347,7 +347,7 @@ struct MultiplicityQa { Preslice perColIU = aod::track::collisionId; using Run3Tracks = soa::Join; - Partition pvContribTracksIUEta1 = (nabs(aod::track::eta) < 1.0f) && ((aod::track::flags & (uint32_t)o2::aod::track::PVContributor) == (uint32_t)o2::aod::track::PVContributor); + Partition pvContribTracksIUEta1 = (nabs(aod::track::eta) < 1.0f) && ((aod::track::flags & static_cast(o2::aod::track::PVContributor)) == static_cast(o2::aod::track::PVContributor)); void processMCCollisions(soa::Join::iterator const& mcCollision, aod::McParticles const& mcParticles, soa::SmallGroups> const& collisions, Run3Tracks const&) { diff --git a/Common/Tasks/qaMuon.cxx b/Common/Tasks/qaMuon.cxx index dd1a9c6d76d..2e5aa56c8e4 100644 --- a/Common/Tasks/qaMuon.cxx +++ b/Common/Tasks/qaMuon.cxx @@ -372,7 +372,7 @@ struct muonQa { // Global muons plots // ====================== int nTrackTypes = static_cast(o2::aod::fwdtrack::ForwardTrackTypeEnum::MCHStandaloneTrack) + 1; - AxisSpec trackTypeAxis = {static_cast(nTrackTypes), 0.0, static_cast(nTrackTypes), "track type"}; + AxisSpec trackTypeAxis = {nTrackTypes, 0.0, static_cast(nTrackTypes), "track type"}; registry.add("global-muons/nTracksPerType", "Number of tracks per type", {HistType::kTH1F, {trackTypeAxis}}); AxisSpec nCandidatesAxis = {static_cast(fNCandidatesMax), 0.0, static_cast(fNCandidatesMax), "match candidate rank"}; @@ -1104,7 +1104,7 @@ struct muonQa { template void TransformMFT(TTrack& track) { - if constexpr (static_cast(GlobalFwdFillMap)) { + if constexpr (GlobalFwdFillMap) { auto mchTrack = mMatching.FwdtoMCH(track); doTransformMFT(mchTrack); @@ -1604,7 +1604,7 @@ struct muonQa { fgValues.nClusters = muon.nClusters(); fgValues.sign = muon.sign(); - if constexpr (static_cast(MuonFillMap)) { + if constexpr (MuonFillMap) { // Direct info from AO2D without re-propagation fgValues.pDca = muon.pDca(); fgValues.rabs = muon.rAtAbsorberEnd(); @@ -1772,7 +1772,7 @@ struct muonQa { fgValues.nClusters = muon.nClusters(); fgValues.sign = muon.sign(); - if constexpr (static_cast(MuonFillMap)) { + if constexpr (MuonFillMap) { o2::dataformats::GlobalFwdTrack track; SMatrix5 tpars(muon.x(), muon.y(), muon.phi(), muon.tgl(), muon.signed1Pt()); @@ -1809,7 +1809,7 @@ struct muonQa { o2::dataformats::GlobalFwdTrack track; - if constexpr (static_cast(Scaled)) { + if constexpr (Scaled) { double pMCH = fgValuesMCH.p; int sign = fgValuesMCH.sign; @@ -1897,7 +1897,7 @@ struct muonQa { float dcaXY = std::sqrt(fgValues.dcaX * fgValues.dcaX + fgValues.dcaY * fgValues.dcaY); fgValues.dcaXY = dcaXY; - if constexpr (static_cast(MuonFillMap)) { + if constexpr (MuonFillMap) { float p = muon.p(); fgValues.pDca = p * dcaXY; } @@ -1920,7 +1920,7 @@ struct muonQa { template void FillMuonHistograms(Var const& fgValuesMCH, Var const& fgValuesMCHpv, Var const& fgValuesMFT, Var const& fgValuesGlobal, VarVector const& fgValuesCandidates) { - if constexpr (static_cast(MuonFillMap)) { + if constexpr (MuonFillMap) { // Muon histograms if (IsGoodMuon(fgValuesMCH, fgValuesMCHpv, 1.E10, configMuons.fPMchLow, configMuons.fPtMchLow, configMuons.fEtaMchLow, configMuons.fEtaMchUp, configMuons.fRabsLow, configMuons.fRabsUp, configMuons.fSigmaPdcaUp)) { registry.get(HIST("muons/TrackChi2"))->Fill(fgValuesMCH.chi2); @@ -1996,7 +1996,7 @@ struct muonQa { } } - if constexpr (static_cast(GlobalMuonFillMap)) { + if constexpr (GlobalMuonFillMap) { // Global muon histograms if (IsGoodMuon(fgValuesMCH, fgValuesMCHpv, 1.E10, configMuons.fPMchLow, configMuons.fPtMchLow, configMFTs.fEtaMftLow, configMFTs.fEtaMftUp, configMuons.fRabsLow, configMuons.fRabsUp, configMuons.fSigmaPdcaUp)) { registry.get(HIST("global-muons/TrackChi2"))->Fill(fgValuesMCH.chi2); @@ -2048,7 +2048,7 @@ struct muonQa { } } - if constexpr (static_cast(GlobalMatchingFillMap)) { + if constexpr (GlobalMatchingFillMap) { // Global muon histograms if (IsGoodMuon(fgValuesMCH, fgValuesMCHpv, 1.E10, configMuons.fPMchLow, configMuons.fPtMchLow, configMFTs.fEtaMftLow, configMFTs.fEtaMftUp, configMuons.fRabsLow, configMuons.fRabsUp, configMuons.fSigmaPdcaUp)) { if (IsGoodGlobalMatching(fgValuesMFT, configMFTs.fTrackChi2MftUp, configMFTs.fTrackNClustMftLow, fMatchingChi2MftMchUp)) { @@ -2155,7 +2155,7 @@ struct muonQa { template void FillDCAHistograms(VarT const& fgValuesMCH, VarT const& fgValuesMCHpv, VarT const& fgValuesMFT, VarC const& fgValuesColl, int sign, int quadrant, bool same, bool mixed) { - if constexpr (static_cast(MuonFillMap)) { + if constexpr (MuonFillMap) { auto phiDeg = fgValuesMCH.phi * 180.f / TMath::Pi(); if (same) { std::get>(dcaHistos[1][quadrant][0]["DCA_x"])->Fill(fgValuesMCH.dcaX); @@ -2184,7 +2184,7 @@ struct muonQa { } } - if constexpr (static_cast(GlobalMuonFillMap)) { + if constexpr (GlobalMuonFillMap) { auto phiDeg = fgValuesMFT.phi * 180.f / TMath::Pi(); if (same) { std::get>(dcaHistos[0][quadrant][0]["DCA_x"])->Fill(fgValuesMFT.dcaX); @@ -2212,7 +2212,7 @@ struct muonQa { } } - if constexpr (static_cast(GlobalMatchingFillMap)) { + if constexpr (GlobalMatchingFillMap) { auto phiDegMCH = fgValuesMCH.phi * 180.f / TMath::Pi(); auto phiDegMFT = fgValuesMFT.phi * 180.f / TMath::Pi(); if (same) { @@ -2290,7 +2290,7 @@ struct muonQa { std::array yPos{yCls, fgValuesProp.y}; double phiClus = std::atan2(yCls, xCls) * 180 / TMath::Pi(); - if constexpr (static_cast(MuonFillMap)) { + if constexpr (MuonFillMap) { if (IsGoodMuon(fgValuesMCH, fgValuesMCHpv, configMuons.fTrackChi2MchUp, 20., configMuons.fPtMchLow, configMFTs.fEtaMftLow, configMFTs.fEtaMftUp, configMuons.fRabsLow, configMuons.fRabsUp, configMuons.fSigmaPdcaUp)) { if (same) { std::get>(mchResidualsHistosPerDE[topBottom][posNeg][chamber]["dx_vs_de"])->Fill(deIndex, xPos[0] - xPos[1]); @@ -2303,7 +2303,7 @@ struct muonQa { } } - if constexpr (static_cast(MFTFillMap)) { + if constexpr (MFTFillMap) { if (IsGoodMuon(fgValuesMCH, fgValuesMCHpv, configMuons.fTrackChi2MchUp, 20., configMuons.fPtMchLow, configMFTs.fEtaMftLow, configMFTs.fEtaMftUp, configMuons.fRabsLow, configMuons.fRabsUp, configMuons.fSigmaPdcaUp)) { if (IsGoodMFT(fgValuesMFT, configMFTs.fTrackChi2MftUp, configMFTs.fTrackNClustMftLow)) { if (same) { @@ -2356,9 +2356,9 @@ struct muonQa { base::Propagator::initFieldFromGRP(grpmag); TrackExtrap::setField(); TrackExtrap::useExtrapV2(); - fieldB = static_cast(TGeoGlobalMagField::Instance()->GetField()); // for MFT - double centerMFT[3] = {0, 0, -61.4}; // or use middle point between Vtx and MFT? - Bz = fieldB->getBz(centerMFT); // Get field at centre of MFT + fieldB = dynamic_cast(TGeoGlobalMagField::Instance()->GetField()); // for MFT + double centerMFT[3] = {0, 0, -61.4}; // or use middle point between Vtx and MFT? + Bz = fieldB->getBz(centerMFT); // Get field at centre of MFT } else { LOGF(fatal, "GRP object is not available in CCDB at timestamp=%llu", bcs.begin().timestamp()); } @@ -2424,7 +2424,7 @@ struct muonQa { typename TMCHTrack, typename VarC, typename VarT> void runDCA(TEventMap const& collisions, TMFTTracks const& mfts, TMFTTrack const& mfttrack, TTrack const& muon, TMCHTrack const& mchtrack, mch::Track const& mchrealigned, VarC& fgValuesColl, VarT& fgValuesMCH, VarT& fgValuesMCHpv, VarT& fgValuesMFT) { - if constexpr (static_cast(MuonFillMap)) { + if constexpr (MuonFillMap) { // track selection if (!IsGoodMuon(fgValuesMCH, fgValuesMCHpv, configMuons.fTrackChi2MchUp, 30., 4., configMFTs.fEtaMftLow, configMFTs.fEtaMftUp, configMuons.fRabsLow, configMuons.fRabsUp, configMuons.fSigmaPdcaUp)) { @@ -2456,7 +2456,7 @@ struct muonQa { } } - if constexpr (static_cast(GlobalMuonFillMap)) { + if constexpr (GlobalMuonFillMap) { auto mftsThisCollision = mfts.sliceBy(mftPerCollision, fgValuesColl.globalIndex); for (auto const& mft : mftsThisCollision) { @@ -2499,7 +2499,7 @@ struct muonQa { } } - if constexpr (static_cast(GlobalMatchingFillMap)) { + if constexpr (GlobalMatchingFillMap) { // track selection if (!IsGoodMuon(fgValuesMCH, fgValuesMCHpv, configMuons.fTrackChi2MchUp, 30., 4., configMFTs.fEtaMftLow, configMFTs.fEtaMftUp, configMuons.fRabsLow, configMuons.fRabsUp, configMuons.fSigmaPdcaUp)) { diff --git a/Common/Tools/Multiplicity/MultModule.h b/Common/Tools/Multiplicity/MultModule.h index 168a5b4488a..e9a64798915 100644 --- a/Common/Tools/Multiplicity/MultModule.h +++ b/Common/Tools/Multiplicity/MultModule.h @@ -688,14 +688,14 @@ class MultModule } if (lCalibObjects) { - hVtxZFV0A = static_cast(lCalibObjects->FindObject("hVtxZFV0A")); - hVtxZFT0A = static_cast(lCalibObjects->FindObject("hVtxZFT0A")); - hVtxZFT0C = static_cast(lCalibObjects->FindObject("hVtxZFT0C")); - hVtxZFDDA = static_cast(lCalibObjects->FindObject("hVtxZFDDA")); - hVtxZFDDC = static_cast(lCalibObjects->FindObject("hVtxZFDDC")); - hVtxZNTracks = static_cast(lCalibObjects->FindObject("hVtxZNTracksPV")); - hVtxZNMFTTracks = static_cast(lCalibObjects->FindObject("hVtxZMFT")); - hVtxZNGlobalTracks = static_cast(lCalibObjects->FindObject("hVtxZNGlobals")); + hVtxZFV0A = dynamic_cast(lCalibObjects->FindObject("hVtxZFV0A")); + hVtxZFT0A = dynamic_cast(lCalibObjects->FindObject("hVtxZFT0A")); + hVtxZFT0C = dynamic_cast(lCalibObjects->FindObject("hVtxZFT0C")); + hVtxZFDDA = dynamic_cast(lCalibObjects->FindObject("hVtxZFDDA")); + hVtxZFDDC = dynamic_cast(lCalibObjects->FindObject("hVtxZFDDC")); + hVtxZNTracks = dynamic_cast(lCalibObjects->FindObject("hVtxZNTracksPV")); + hVtxZNMFTTracks = dynamic_cast(lCalibObjects->FindObject("hVtxZMFT")); + hVtxZNGlobalTracks = dynamic_cast(lCalibObjects->FindObject("hVtxZNGlobals")); lCalibLoaded = true; // Capture error if (!hVtxZFV0A || !hVtxZFT0A || !hVtxZFT0C || !hVtxZFDDA || !hVtxZFDDC || !hVtxZNTracks) { @@ -1098,11 +1098,11 @@ class MultModule Run2CL1Info.mCalibrationStored = false; if (callst != nullptr) { auto getccdb = [callst](const char* ccdbhname) { - TH1* h = reinterpret_cast(callst->FindObject(ccdbhname)); + TH1* h = dynamic_cast(callst->FindObject(ccdbhname)); return h; }; auto getformulaccdb = [callst](const char* ccdbhname) { - TFormula* f = reinterpret_cast(callst->FindObject(ccdbhname)); + TFormula* f = dynamic_cast(callst->FindObject(ccdbhname)); return f; }; @@ -1253,8 +1253,8 @@ class MultModule if (callst != nullptr) { LOGF(info, "Getting new histograms with %d run number for %d run number", mRunNumber, bc.runNumber()); auto getccdb = [callst, bc](struct CalibrationInfo& estimator, const o2::framework::Configurable& generatorName) { // TODO: to consider the name inside the estimator structure - estimator.mhMultSelCalib = reinterpret_cast(callst->FindObject(TString::Format("hCalibZeq%s", estimator.name.c_str()).Data())); - estimator.mMCScale = reinterpret_cast(callst->FindObject(TString::Format("%s-%s", generatorName->c_str(), estimator.name.c_str()).Data())); + estimator.mhMultSelCalib = dynamic_cast(callst->FindObject(TString::Format("hCalibZeq%s", estimator.name.c_str()).Data())); + estimator.mMCScale = dynamic_cast(callst->FindObject(TString::Format("%s-%s", generatorName->c_str(), estimator.name.c_str()).Data())); if (estimator.mhMultSelCalib != nullptr) { if (generatorName->length() != 0) { LOGF(info, "Retrieving MC calibration for %d, generator name: %s", bc.runNumber(), generatorName->c_str()); diff --git a/Common/Tools/Multiplicity/macros/runCalibration.C b/Common/Tools/Multiplicity/macros/runCalibration.C index 0620bb5e1db..1e1d4f96b5f 100644 --- a/Common/Tools/Multiplicity/macros/runCalibration.C +++ b/Common/Tools/Multiplicity/macros/runCalibration.C @@ -38,12 +38,12 @@ void runCalibration(const TString& lInputFileName = "results/AR_544122_glauberNB TFile* file = new TFile(lInputFileName.Data(), "READ"); file->ls(); - TH1F* hData = (TH1F*)file->Get("hV0MUltraFine"); - TH1F* hGlauberParameters = (TH1F*)file->Get("hGlauberParameters"); - TH1F* hGlauberFitRange = (TH1F*)file->Get("hGlauberFitRange"); + TH1F* hData = dynamic_cast(file->Get("hV0MUltraFine")); + TH1F* hGlauberParameters = dynamic_cast(file->Get("hGlauberParameters")); + TH1F* hGlauberFitRange = dynamic_cast(file->Get("hGlauberFitRange")); hData->SetName("hData"); - TH1F* hStitched = (TH1F*)hData->Clone("hStitched"); - TH1F* hFit = (TH1F*)file->Get("hGlauber"); + TH1F* hStitched = dynamic_cast(hData->Clone("hStitched")); + TH1F* hFit = dynamic_cast(file->Get("hGlauber")); TCanvas* c1 = new TCanvas("c1", "", 800, 600); c1->SetLeftMargin(0.17); @@ -160,7 +160,7 @@ void runCalibration(const TString& lInputFileName = "results/AR_544122_glauberNB // Step 1: open the (Npart, Ncoll) pair information, provide TFile* fbasefile = new TFile("basehistos.root", "READ"); - TH2D* hNpNc = (TH2D*)fbasefile->Get("hNpNc"); + TH2D* hNpNc = dynamic_cast(fbasefile->Get("hNpNc")); g->SetNpartNcollCorrelation(hNpNc); g->InitializeNpNc(); diff --git a/Common/Tools/Multiplicity/macros/runGlauberFit.C b/Common/Tools/Multiplicity/macros/runGlauberFit.C index 5c07a000405..9524985b1ff 100644 --- a/Common/Tools/Multiplicity/macros/runGlauberFit.C +++ b/Common/Tools/Multiplicity/macros/runGlauberFit.C @@ -39,9 +39,9 @@ Double_t FastIntegrate(TF1* f1, Double_t a, Double_t b, Int_t n = 5) // Do fast integration with N sampling points const Int_t nc = n; Double_t x[nc], y[nc]; - Double_t lWidth = (b - a) / ((double)(n - 1)); + Double_t lWidth = (b - a) / (static_cast(n - 1)); for (Int_t ii = 0; ii < n; ii++) { - x[ii] = a + ((double)(ii)) * lWidth; + x[ii] = a + (static_cast(ii)) * lWidth; y[ii] = f1->Eval(x[ii]); } // Now go via trapezoids, please (this probably has a name) @@ -98,7 +98,7 @@ int runGlauberFit(const TString& lInputFileName = "AnalysisResultsLHC24ar.root", std::cout << "Problem with file!" << std::endl; TH1F* hV0Mfine = 0x0; - hV0Mfine = (TH1F*)file->Get(Form("centrality-study/%s", histogramName.Data())); + hV0Mfine = dynamic_cast(file->Get(Form("centrality-study/%s", histogramName.Data()))); // disregard bin zero std::cout << "Received bin zero content: " << hV0Mfine->GetBinContent(0) << ", will set to zero..." << std::endl; @@ -124,8 +124,8 @@ int runGlauberFit(const TString& lInputFileName = "AnalysisResultsLHC24ar.root", TFile* fOutput = new TFile(outputFile.Data(), "RECREATE"); - TH1F* hV0M = (TH1F*)hV0Mfine->Clone("hV0M"); - TH1F* hV0MUltraFine = (TH1F*)hV0Mfine->Clone("hV0MUltraFine"); + TH1F* hV0M = dynamic_cast(hV0Mfine->Clone("hV0M")); + TH1F* hV0MUltraFine = dynamic_cast(hV0Mfine->Clone("hV0MUltraFine")); hV0M->SetName("hV0M"); hV0M->SetTitle(""); @@ -210,7 +210,7 @@ int runGlauberFit(const TString& lInputFileName = "AnalysisResultsLHC24ar.root", // Step 1: open the (Npart, Ncoll) pair information, provide TFile* fbasefile = new TFile("basehistos.root", "READ"); - TH2D* hNpNc = (TH2D*)fbasefile->Get("hNpNc"); + TH2D* hNpNc = dynamic_cast(fbasefile->Get("hNpNc")); // return to proper scope fOutput->cd(); g->SetNpartNcollCorrelation(hNpNc); @@ -291,8 +291,8 @@ int runGlauberFit(const TString& lInputFileName = "AnalysisResultsLHC24ar.root", gStyle->SetOptStat(0); // Do a ratio plot - TH1D* hGlauber = (TH1D*)hV0MUltraFine->Clone("hGlauber"); - TH1D* hRatio = (TH1D*)hV0MUltraFine->Clone("hRatio"); + TH1D* hGlauber = dynamic_cast(hV0MUltraFine->Clone("hGlauber")); + TH1D* hRatio = dynamic_cast(hV0MUltraFine->Clone("hRatio")); hGlauber->Reset(); c1->cd(1); @@ -345,7 +345,7 @@ int runGlauberFit(const TString& lInputFileName = "AnalysisResultsLHC24ar.root", lFitRangeLine->SetLineStyle(2); lFitRangeLine->Draw(); - TH1D* hRatioGrayed = (TH1D*)hRatio->Clone("hRatioGrayed"); + TH1D* hRatioGrayed = dynamic_cast(hRatio->Clone("hRatioGrayed")); hRatioGrayed->SetMarkerColor(kGray + 2); hRatioGrayed->SetLineColor(kGray + 2); hRatioGrayed->Draw("same"); diff --git a/Common/Tools/Multiplicity/macros/saveCorrelation.C b/Common/Tools/Multiplicity/macros/saveCorrelation.C index 73bf8d30f29..04b27fc6c1b 100644 --- a/Common/Tools/Multiplicity/macros/saveCorrelation.C +++ b/Common/Tools/Multiplicity/macros/saveCorrelation.C @@ -29,23 +29,23 @@ void saveCorrelation(const TString& filename = "gmc-PbPb-snn68.21-md0.40-nd-1.0-rc1-smax99.0.root", const TString& outputFile = "basehistos.root") { TFile* fin = new TFile(filename.Data(), "READ"); - TNtuple* ntup = (TNtuple*)fin->Get("nt_Pb_Pb"); + TNtuple* ntup = dynamic_cast(fin->Get("nt_Pb_Pb")); // try other Pb nuclear profiles in case "Pb" - "Pb" not found if (!ntup) { - ntup = (TNtuple*)fin->Get("nt_Pbpn_Pbpn"); + ntup = dynamic_cast(fin->Get("nt_Pbpn_Pbpn")); } if (!ntup) { - ntup = (TNtuple*)fin->Get("nt_PbpnVar1_PbpnVar1"); + ntup = dynamic_cast(fin->Get("nt_PbpnVar1_PbpnVar1")); } if (!ntup) { - ntup = (TNtuple*)fin->Get("nt_PbpnVar2_PbpnVar2"); + ntup = dynamic_cast(fin->Get("nt_PbpnVar2_PbpnVar2")); } if (!ntup) { - ntup = (TNtuple*)fin->Get("nt_PbpnVar3_PbpnVar3"); + ntup = dynamic_cast(fin->Get("nt_PbpnVar3_PbpnVar3")); } if (!ntup) { - ntup = (TNtuple*)fin->Get("nt_PbpnVar4_PbpnVar4"); + ntup = dynamic_cast(fin->Get("nt_PbpnVar4_PbpnVar4")); } if (!ntup) { diff --git a/Common/Tools/Multiplicity/multCalibrator.cxx b/Common/Tools/Multiplicity/multCalibrator.cxx index 964bb468b72..8d25df8e32e 100644 --- a/Common/Tools/Multiplicity/multCalibrator.cxx +++ b/Common/Tools/Multiplicity/multCalibrator.cxx @@ -108,7 +108,7 @@ Bool_t multCalibrator::Calibrate() // Step 1: verify if input file contains desired histograms TH1D* hRaw[kNCentEstim]; for (Int_t iv = 0; iv < kNCentEstim; iv++) { - hRaw[iv] = reinterpret_cast(fileInput->Get(Form("multiplicity-qa/multiplicityQa/h%s", fCentEstimName[iv].Data()))); + hRaw[iv] = dynamic_cast(fileInput->Get(Form("multiplicity-qa/multiplicityQa/h%s", fCentEstimName[iv].Data()))); if (!hRaw[iv]) { cout << Form("File does not contain histogram h%s, which is necessary for calibration!", fCentEstimName[iv].Data()) << endl; return kFALSE; diff --git a/Common/Tools/Multiplicity/multMCCalibrator.cxx b/Common/Tools/Multiplicity/multMCCalibrator.cxx index be3bd71596f..9567200ed84 100644 --- a/Common/Tools/Multiplicity/multMCCalibrator.cxx +++ b/Common/Tools/Multiplicity/multMCCalibrator.cxx @@ -91,13 +91,13 @@ Bool_t multMCCalibrator::Calibrate() TProfile* hProfSim[multCalibrator::kNCentEstim]; cout << " * acquiring input profiles..." << endl; for (Int_t iv = 0; iv < multCalibrator::kNCentEstim; iv++) { - hProfData[iv] = reinterpret_cast(fileData->Get(Form("multiplicity-qa/multiplicityQa/hProf%s", multCalibrator::fCentEstimName[iv].Data()))); + hProfData[iv] = dynamic_cast(fileData->Get(Form("multiplicity-qa/multiplicityQa/hProf%s", multCalibrator::fCentEstimName[iv].Data()))); if (!hProfData[iv]) { cout << Form("Data file does not contain histogram h%s, which is necessary for calibration!", multCalibrator::fCentEstimName[iv].Data()) << endl; return kFALSE; } hProfData[iv]->SetName(Form("hProfData_%s", multCalibrator::fCentEstimName[iv].Data())); - hProfSim[iv] = reinterpret_cast(fileSim->Get(Form("multiplicity-qa/multiplicityQa/hProf%s", multCalibrator::fCentEstimName[iv].Data()))); + hProfSim[iv] = dynamic_cast(fileSim->Get(Form("multiplicity-qa/multiplicityQa/hProf%s", multCalibrator::fCentEstimName[iv].Data()))); if (!hProfSim[iv]) { cout << Form("Sim file does not contain histogram h%s, which is necessary for calibration!", multCalibrator::fCentEstimName[iv].Data()) << endl; return kFALSE; diff --git a/Common/Tools/PID/checkPidPacking.cxx b/Common/Tools/PID/checkPidPacking.cxx index dc497240ef3..1147f27be98 100644 --- a/Common/Tools/PID/checkPidPacking.cxx +++ b/Common/Tools/PID/checkPidPacking.cxx @@ -49,14 +49,14 @@ bool process(std::string outputName, int nevents = 100000) LOG(info) << "Bin width = " << T::bin_width << " vs histo " << hgaus->GetXaxis()->GetBinWidth(1); hgaus->SetLineColor(2); hgaus->SetLineStyle(1); - TH1F* hgausPacked = static_cast(hgaus->Clone("hgausPacked")); + TH1F* hgausPacked = dynamic_cast(hgaus->Clone("hgausPacked")); hgausPacked->SetLineColor(4); hgausPacked->SetLineStyle(2); - TH1F* huniform = static_cast(hgaus->Clone("huniform")); + TH1F* huniform = dynamic_cast(hgaus->Clone("huniform")); huniform->SetLineColor(2); huniform->SetLineStyle(1); - TH1F* huniformPacked = static_cast(hgaus->Clone("huniformPacked")); + TH1F* huniformPacked = dynamic_cast(hgaus->Clone("huniformPacked")); huniformPacked->SetLineColor(4); huniformPacked->SetLineStyle(2); diff --git a/Common/Tools/TrackPropagationModule.h b/Common/Tools/TrackPropagationModule.h index d7f7dd6a75d..2583b2c9bed 100644 --- a/Common/Tools/TrackPropagationModule.h +++ b/Common/Tools/TrackPropagationModule.h @@ -316,7 +316,7 @@ class TrackPropagationModule } } // auto trackParCov = getTrackParCov(track); - o2::aod::track::TrackTypeEnum trackType = (o2::aod::track::TrackTypeEnum)track.trackType(); + o2::aod::track::TrackTypeEnum trackType{track.trackType()}; // std::array trackPxPyPz; // std::array trackPxPyPzTuned = {0.0, 0.0, 0.0}; double q2OverPtNew = -9999.;