Repository navigation
Remove software-properties-common after adding git PPA - #71
Merged
Merged
Conversation
It pulled python3-jwt 2.3.0 into the image (CVE-2026-102268, critical in Docker Scout).
Up to standards ✅🟢 Issues
|
lolgab
approved these changes
Oct 22, 2026
pedrobpereira
marked this pull request as ready for review
October 22, 2026 16:02
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull Request Overview
👀 Worth a closer look
The acceptance criteria lack verification: there are no tests or documented evidence that the package was purged, that python3-jwt is absent, or that Git remains available afterward. The Dockerfile is also identified as having no automated coverage information.
About this PR
- Please add verification for the image build and package state, including confirmation that software-properties-common and python3-jwt are absent and Git remains available after the purge.
Test suggestions
- Build the image and verify that software-properties-common is not installed.
- Build the image and verify that python3-jwt is no longer installed.
- Verify that Git installed from the configured PPA remains available after the purge.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Build the image and verify that software-properties-common is not installed.
2. Build the image and verify that python3-jwt is no longer installed.
3. Verify that Git installed from the configured PPA remains available after the purge.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Removes software-properties-common from the base image once the git PPA is added, which drops the python3-jwt 2.3.0 package flagged as CVE-2026-102268.
Manual Testing
Add manual testing evidence here (steps, screenshots, environment).