Repository navigation
Specify void this for TimerHandler callbacks - #2575
Open
Flpvoigt (Flpvoigt) wants to merge 1 commit into
Open
Flpvoigt (Flpvoigt) wants to merge 1 commit into
Flpvoigt (Flpvoigt) wants to merge 1 commit into
Conversation
Contributor
|
Thanks for the PR! This section of the codebase is owned by Kagami Sascha Rosylight (@saschanaz) - if they write a comment saying "LGTM" then it will be merged. |
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Functionmember ofTimerHandlerwith an explicit callback signature.thisparameter asvoid.This implements the library-definition portion discussed in microsoft/TypeScript#10285. Implicit
thistyping for unannotated methods remains tracked by microsoft/TypeScript#10288.Tests
npm testAI assistance
I used OpenAI Codex to help inspect the repositories, identify the generator source, and review the generated changes. I manually applied and reviewed the source change and ran the tests.