From c47b81bd0b66845ff3069b4544ce5d3c54879ac2 Mon Sep 17 00:00:00 2001 From: Stanislas Kita <7335054+stonebuzz@users.noreply.github.com> Date: Wed, 21 Oct 2026 08:57:14 +0200 Subject: [PATCH 1/2] Fix(E2E): expect redirect to created ticket in e2e form tests --- CHANGELOG.md | 2 +- tests/e2e/specs/reservation_question.spec.ts | 2 +- tests/e2e/specs/table_question.spec.ts | 8 ++++---- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e60669c..87cee33 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,7 +5,7 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/). -## [Unreleased] +## [UNRELEASED] ### Fixed diff --git a/tests/e2e/specs/reservation_question.spec.ts b/tests/e2e/specs/reservation_question.spec.ts index 9efecc7..6e1b662 100644 --- a/tests/e2e/specs/reservation_question.spec.ts +++ b/tests/e2e/specs/reservation_question.spec.ts @@ -106,7 +106,7 @@ test.describe('Advanced forms - Material reservation question', () => { await expect(reservation.getAvailabilityMessage(widget)).toHaveText('This slot is available'); await page.getByRole('button', { name: 'Submit' }).click(); - await expect(page.getByRole('alert').getByRole('link', { name: form_name })).toBeVisible(); + await expect(page).toHaveURL(/\/front\/ticket\.form\.php\?id=\d+/); }); }); diff --git a/tests/e2e/specs/table_question.spec.ts b/tests/e2e/specs/table_question.spec.ts index dfca6f3..93f14bd 100644 --- a/tests/e2e/specs/table_question.spec.ts +++ b/tests/e2e/specs/table_question.spec.ts @@ -106,8 +106,8 @@ test.describe('Advanced forms - Table question', () => { await page.getByRole('button', { name: 'Submit' }).click(); - // A link to the created answer/item confirms the submission succeeded. - await expect(page.getByRole('alert').getByRole('link', { name: form_name })).toBeVisible(); + // Being redirected to the created ticket confirms the submission succeeded. + await expect(page).toHaveURL(/\/front\/ticket\.form\.php\?id=\d+/); }); }); @@ -178,7 +178,7 @@ test.describe('Advanced forms - Table question', () => { await expect(table.getEndUserCell(eu_table, 0, 0)).not.toHaveClass(/is-invalid/); await page.getByRole('button', { name: 'Submit' }).click(); - await expect(page.getByRole('alert').getByRole('link', { name: form_name })).toBeVisible(); + await expect(page).toHaveURL(/\/front\/ticket\.form\.php\?id=\d+/); }); }); @@ -222,7 +222,7 @@ test.describe('Advanced forms - Table question', () => { await page.getByRole('button', { name: 'Submit' }).click(); - await expect(page.getByRole('alert').getByRole('link', { name: form_name })).toBeVisible(); + await expect(page).toHaveURL(/\/front\/ticket\.form\.php\?id=\d+/); }); }); From 6e3a86862048400b7a275ab04dc8ca2d0c63dc00 Mon Sep 17 00:00:00 2001 From: Rom1-B <8530352+Rom1-B@users.noreply.github.com> Date: Wed, 21 Oct 2026 09:06:33 +0200 Subject: [PATCH 2/2] check created ticket title after form submit --- tests/e2e/specs/reservation_question.spec.ts | 1 + tests/e2e/specs/table_question.spec.ts | 3 +++ 2 files changed, 4 insertions(+) diff --git a/tests/e2e/specs/reservation_question.spec.ts b/tests/e2e/specs/reservation_question.spec.ts index 6e1b662..5e46fc0 100644 --- a/tests/e2e/specs/reservation_question.spec.ts +++ b/tests/e2e/specs/reservation_question.spec.ts @@ -107,6 +107,7 @@ test.describe('Advanced forms - Material reservation question', () => { await page.getByRole('button', { name: 'Submit' }).click(); await expect(page).toHaveURL(/\/front\/ticket\.form\.php\?id=\d+/); + await expect(page.getByRole('heading')).toContainText(form_name); }); }); diff --git a/tests/e2e/specs/table_question.spec.ts b/tests/e2e/specs/table_question.spec.ts index 93f14bd..ec7765f 100644 --- a/tests/e2e/specs/table_question.spec.ts +++ b/tests/e2e/specs/table_question.spec.ts @@ -108,6 +108,7 @@ test.describe('Advanced forms - Table question', () => { // Being redirected to the created ticket confirms the submission succeeded. await expect(page).toHaveURL(/\/front\/ticket\.form\.php\?id=\d+/); + await expect(page.getByRole('heading')).toContainText(form_name); }); }); @@ -179,6 +180,7 @@ test.describe('Advanced forms - Table question', () => { await page.getByRole('button', { name: 'Submit' }).click(); await expect(page).toHaveURL(/\/front\/ticket\.form\.php\?id=\d+/); + await expect(page.getByRole('heading')).toContainText(form_name); }); }); @@ -223,6 +225,7 @@ test.describe('Advanced forms - Table question', () => { await page.getByRole('button', { name: 'Submit' }).click(); await expect(page).toHaveURL(/\/front\/ticket\.form\.php\?id=\d+/); + await expect(page.getByRole('heading')).toContainText(form_name); }); });