Repository navigation
Fix #4426: preserve JDK_HOME priority when sorting JDKs - #4427
Merged
Merged
Conversation
shblue21
force-pushed
the
fix-jdk-home-priority
branch
from
June 16, 2026 12:05
af0ac84 to
b915526
Compare
shblue21
force-pushed
the
fix-jdk-home-priority
branch
from
June 16, 2026 12:05
b915526 to
4bf7d1e
Compare
Contributor
|
@MeherSru Can you test this PR please? |
MeherSru
approved these changes
Oct 19, 2026
MeherSru
left a comment
MeherSru
left a comment
Contributor
There was a problem hiding this comment.
with JDK_HOME=26 and JAVA_HOME=25, main picks 25, and with this fix it picks 26. Works as expected, LGTM 👍
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JDK_HOME is assigned the highest source priority in sortJdksBySource(), but the rank check treated rank 0 as if no rank had been assigned. That allowed later source ranking to overwrite the JDK_HOME entry and sort it after lower-priority detected JDKs.
This changes the check to look for an assigned numeric rank and adds a regression test for the ordering.
Fixes #4426