Repository navigation
Conversation
…tion parser to FT0 task
…ues in FT0DataProcessor
…r of channels in FT0 configuration to 208
…static memory corruption issue in HV schema; fixed schema issues in both FEE and HV
…to FITDCSConfigProcessor, added back DeadChannelMap definition in link file'
Please consider the following formatting changes to AliceO2Group#15888
| // granted to it by virtue of its status as an Intergovernmental Organization | ||
| // or submit itself to any jurisdiction. | ||
|
|
||
| // \file FeeConfiguration.h |
There was a problem hiding this comment.
correct filename in comments
| uint16_t adcDelays[NChannels]; | ||
| uint16_t rangeCorrectionAdc0[NChannels]; | ||
| uint16_t rangeCorrectionAdc1[NChannels]; | ||
| uint16_t thresholdCalibration[NChannels]; |
There was a problem hiding this comment.
thresholdCalibration is not included later in operator==(const ChannelsConfig& other) comparison and also not defined as a getter. Any specific reasons ?
|
|
||
| template <int NChannels> | ||
| struct ChannelsConfig { | ||
| int16_t timeAligments[NChannels]; |
There was a problem hiding this comment.
Spelling of "Alignment" is incorrect almost throughout the draft.
| o2::fit::ChannelsConfig<NChannels> channels; | ||
| o2::fit::TcmConfig tcm; | ||
| o2::fit::PmConfig pmA[10]; | ||
| o2::fit::PmConfig pmC[10]; |
There was a problem hiding this comment.
Do we keep this array of 10 or make it 12 ?
It is your choice, because probably we will not use all 12 channels ever..
But I was thinking if, just in case, there are some tests later then we can have a matching size of array with the no. of PM channels.
There was a problem hiding this comment.
Why would you make it 12? There are at most 10 PM modules per side
This branch has not been deployed
3 participants
Implementation of FEE configuration CCDB object and DCS workflow that fetches JSON from DCS and transforms it to the CCDB object