[graduta]

I have a JIRA ticket

• branch and/or PR name(s) include(s) JIRA ID
• issue has "Fix version" assigned
• issue "Status" is set to "In review"
• PR labels are selected

docs/backend-architecture.md plans to replace the usecases by controllers and services. This PR migrates two more resources that were still read through use cases, the ones found while documenting the HTTP API (O2B-1623): status and tags (the run types ones were migrated in #2267).

Notable changes for users:

• None: the responses of /api/status/* and /api/tags/* are unchanged, including the 404 bodies of the tags endpoints (the GUI and the tests rely on them).

Notable changes for developers:

• StatusService (getGuiStatus, getDatabaseStatus) replaces GetGuiStatusUseCase and GetDatabaseStatusUseCase. The service receives the host and the port instead of the express request. The 501 branches of the controller are removed, they could not happen as the use cases never returned null.
• TagService (getAll, getByIdentifier, create, update, remove, getLogs) replaces the seven tag use cases. It is built on two small functions returning models, getTag and getAllTags, like it is done for detectors, and uses dataSource.transaction like the other services. The user id and the new values are given explicitly instead of a DTO with a session, and create no longer mutates the values it receives.
• lib/usecases/status, lib/usecases/tag and their tests are removed, replaced by StatusService and TagService tests (the tests creating or updating a tag through a use case use the service). The unreachable-database test now restores its database.ping stub instead of leaving it replaced for the following tests.
• Checked with the repositories stubbed (no database available when writing it): ordering and filters of getAll, null for a missing tag, the errors messages of create and update. The new and moved tests have not been run, only the CI does.

Changes made to the database:

• None

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.16%. Comparing base (19720a1) to head (43754e3).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2277      +/-   ##
==========================================
- Coverage   46.36%   46.16%   -0.20%     
==========================================
  Files        1049     1042       -7     
  Lines       17351    17295      -56     
  Branches     3160     3157       -3     
==========================================
- Hits         8044     7984      -60     
- Misses       9307     9311       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.