Skip to content

[PWGEM/PhotonMeson] Enable cross section normalization in generator task - #18355

Merged
mhemmer-cern merged 1 commit into
AliceO2Group:masterfrom
nstrangm:master
Oct 19, 2026
Merged

mhemmer-cern merged 1 commit into
AliceO2Group:masterfrom
nstrangm:master

Conversation

@nstrangm

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions github-actions Bot added pwgem photon Photon and neutral meson PAG label labels Oct 19, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 3 warnings, 🔕 0 disabled

@nstrangm
nstrangm marked this pull request as ready for review October 19, 2026 13:30
mhemmer-cern
mhemmer-cern previously approved these changes Oct 19, 2026

@mhemmer-cern mhemmer-cern left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 4b51a5f at 2026-10-19 15:55:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 2 errors and 1 warnings.'
Found 2 errors and 1 warnings.
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/398f720565edf545cd519afaa1460e79e3a13fb3/O2Physics-code-check/errors.txt
PWGEM/PhotonMeson/Tasks/mcGeneratorStudies.cxx:41:31: error: no header providing "Form" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/Tasks/mcGeneratorStudies.cxx:44:32: error: no header providing "TH1" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/398f720565edf545cd519afaa1460e79e3a13fb3/O2Physics-code-check/warnings.txt
PWGEM/PhotonMeson/Tasks/mcGeneratorStudies.cxx:91:36: warning: statement should be inside braces [readability-braces-around-statements]
++ [[ 2 -gt 0 ]]
++ exit 1
--

Full log here.

@mhemmer-cern
mhemmer-cern merged commit ea53c75 into AliceO2Group:master Oct 19, 2026
20 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

photon Photon and neutral meson PAG label pwgem

Development

Successfully merging this pull request may close these issues.

3 participants