Skip to content

[PWGLF] Remove correlation analysis - #18416

Draft
alcaliva wants to merge 2 commits into
AliceO2Group:masterfrom
alcaliva:master
Draft

alcaliva wants to merge 2 commits into
AliceO2Group:masterfrom
alcaliva:master

Conversation

@alcaliva

Copy link
Copy Markdown
Collaborator
  • Removed functions and histograms related to correlation analysis (to be moved to a separate task).
  • Refactored the code and removed unused functions and variables.

@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for b534b89 at 2026-10-22 17:41:

No log files found

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for b534b89 at 2026-10-22 17:41:

No log files found

Full log here.

@vkucera
vkucera marked this pull request as draft October 22, 2026 16:44
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for b534b89 at 2026-10-22 20:02:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 4 errors and 234 warnings.'
Found 4 errors and 234 warnings.
++ [[ 4 -gt 0 ]]
++ cat /sw/BUILD/0218fb555d4dc845ae10a52744f767492c82215e/O2Physics-code-check/errors.txt
PWGLF/Tasks/Nuspex/antinucleiInJets.cxx:64:1: error: included header algorithm is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/antinucleiInJets.cxx:67:1: error: included header cstddef is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Nuspex/antinucleiInJets.cxx:1829:9: error: variable 'eventCounter' set but not used [clang-diagnostic-unused-but-set-variable,-warnings-as-errors]
PWGLF/Tasks/Nuspex/antinucleiInJets.cxx:2089:9: error: variable 'eventCounter' set but not used [clang-diagnostic-unused-but-set-variable,-warnings-as-errors]
++ [[ 234 -gt 0 ]]
++ cat /sw/BUILD/0218fb555d4dc845ae10a52744f767492c82215e/O2Physics-code-check/warnings.txt
PWGLF/Tasks/Nuspex/antinucleiInJets.cxx:99:3: warning: function 'eta' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGLF/Tasks/Nuspex/antinucleiInJets.cxx:109:3: warning: function 'phi' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGLF/Tasks/Nuspex/antinucleiInJets.cxx:116:3: warning: function 'pt' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGLF/Tasks/Nuspex/antinucleiInJets.cxx:570:5: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
PWGLF/Tasks/Nuspex/antinucleiInJets.cxx:610:37: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/antinucleiInJets.cxx:624:39: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/antinucleiInJets.cxx:636:9: warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
PWGLF/Tasks/Nuspex/antinucleiInJets.cxx:636:187: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/antinucleiInJets.cxx:776:20: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/antinucleiInJets.cxx:778:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/antinucleiInJets.cxx:804:25: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/antinucleiInJets.cxx:806:84: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/antinucleiInJets.cxx:808:25: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/antinucleiInJets.cxx:810:47: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/antinucleiInJets.cxx:812:41: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/antinucleiInJets.cxx:814:41: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/antinucleiInJets.cxx:816:41: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/antinucleiInJets.cxx:818:36: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/antinucleiInJets.cxx:820:118: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/antinucleiInJets.cxx:822:48: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/antinucleiInJets.cxx:831:60: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/antinucleiInJets.cxx:833:25: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/antinucleiInJets.cxx:835:84: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/antinucleiInJets.cxx:837:43: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/antinucleiInJets.cxx:839:25: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/antinucleiInJets.cxx:841:57: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/antinucleiInJets.cxx:843:46: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/antinucleiInJets.cxx:845:46: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/antinucleiInJets.cxx:847:46: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/antinucleiInJets.cxx:849:54: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants