Repository navigation
Conversation
Add selected-event generated denominators and reconstructed response histograms for the XiK0s and Xi1530K channels. Match reconstructed mothers to the parent table and apply consistent truth-rapidity, kinematic and optional injected-generator selections. Share Omega2012 event-selection defaults between analysis and ML export. Use an independent generated-mother rapidity limit so the audit includes selected events without candidates while preserving the loose candidate rapidity acceptance.
|
O2 linter results: ❌ 0 errors, |
|
Error while checking build/O2Physics/code-check for 132b8b8 at 2026-10-23 14:41: Full log here. |
|
@BongHwi Please do not merge the PR with errors. |
Mark MC-only callback parameters as maybe_unused and remove redundant integer casts. Bind fixed-size daughter index arrays by reference. Keep the persistent K1 feature column format and document its narrow exception to modernize-avoid-c-arrays.
|
Thanks @vkucera , I clicked the merge before I found the error! |
|
@BongHwi It seems you don't own any of the files so enabling auto-merge is quite counterproductive because it will need to be disabled by someone anyway. |
|
I get the concern, but these are actually classes I manage (if you meant the I usually enable auto-merge because of the Asia time difference, it helps the PR get merged (if it is approved meanwhile) before midnight while I'm asleep so it makes the daily tag build. Happy to leave it off though if that’s our convention! |
I don't think you understand how auto-merge works. You are actually blocking the merging by enabling the auto-merge. Please read documentation in the contribution guidelines and the last line of the action output:
|
This updates the Omega2012 and K1 MC analysis and export paths so efficiency numerators can be compared with generated mothers from the same selected events and rapidity range.
For Omega2012:
For K1:
K1 reconstructed MC processing now requires
ResoMCParents_001, including when generated processing is disabled. The existingMCReco/pthistogram remains a QA distribution; efficiency calculations should use the new response histograms.