Repository navigation
[PWGEM,PWGJE] EMCal TM monitor: MC truth of the track matching chain - #18443
Merged
Merged
Conversation
The EMCal track-matching veto misses many clusters made by conversion
electrons (PCM photons counted twice in PCM-EMC pairs). The derived data
cannot tell where the matching chain fails, so add an MC truth process
that follows the leading MC particle of each cluster through it.
emcTmMonitor:
- New processMCTruth (off by default). For every cluster, take the
leading MC contributor (largest energy fraction) and classify it as
conversion e+-, primary e+-, other e+-, other charged, photon, neutral
or other.
- For charged leading particles, follow the particle's best
reconstructed track and record one status per cluster: no reco track,
not extrapolated to the EMCal, no matching candidate (neither a global
track nor a V0 leg), candidate not matched, matched as primary,
matched as secondary.
- Histograms under MCTruth/:
- status vs truth class, track type, V0-leg flag and MC pT
- track-cluster residuals up to +-0.4 in the origin frame of the
extrapolation, so tails beyond the matching windows are visible
- own residual minus stored residual, to validate the frame conversion
- status vs conversion radius
- E/p of conversion-e+- clusters
- Needs emcal-correction-task with processMCWithSecondaries and the
photon conversion builder (aod::V0Legs).
- The event selection moves into a helper shared by both process
functions; the event histograms are filled only once.
- Charges come from the O2DatabasePDG service.
- Histograms with labelled axes are TH2 or THn, avoiding the TH3 label
merge bug in ROOT 6.36.
- Add missing BC table to process functions for event selecton which needs
it to get the runnumber via collision -> bc -> runnumber
twoPhotonMcTask:
- hOrigin: disable axis extension on the labelled z axis.
TH1Merger::LabelMerge in ROOT 6.36 reads the z labels from the y axis,
so merged content ended up in a new, unlabelled bin.
- Leg matching diagnostics: evaluate the primary-match status only for
legs that pass the global track selection (rebuilt from the V0Legs
columns); other legs get a new "not a global track" status instead of
inflating "no match stored".
Co-Authored-By: Claude Opus 5.5
Fix missing BC table in process functions
mhemmer-cern
requested review from
alibuild,
amaringarcia,
dsekihat,
fjonasALICE,
hscheid,
jaimenorman,
jokonig,
nzardosh and
reygers
as code owners
October 23, 2026 13:46
|
O2 linter results: ❌ 0 errors, |
Collaborator
Author
|
Did locally build and run, without any code check issues, so let's hope online its the same. |
mhemmer-cern
enabled auto-merge (squash)
October 23, 2026 18:27
alibuild
approved these changes
Oct 23, 2026
alibuild
left a comment
Collaborator
There was a problem hiding this comment.
Auto-approving on behalf of @mhemmer-cern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The EMCal track-matching veto misses many clusters made by conversion electrons (PCM photons counted twice in PCM-EMC pairs). The derived data cannot tell where the matching chain fails, so add an MC truth process that follows the leading MC particle of each cluster through it.
emcTmMonitor:
twoPhotonMcTask:
Co-Authored-By: Claude Opus 5.5
Fix missing BC table in process functions