Repository navigation
fix: preserve timeline clip gain during audio export - #24
Open
JaysonAlbert wants to merge 1 commit into
Open
JaysonAlbert wants to merge 1 commit into
JaysonAlbert wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sequential timeline clips lost gain during MCP export because FFmpeg normalized the mix across every input, including delayed silence. Export now preserves the configured clip gains and applies a peak limiter without automatic makeup gain or lookahead delay.
Fixes #23.
Validation: two FFmpeg audio regression tests pass (unity gain across three delayed sequential clips; bounded peaks and unchanged duration for overlapping loud tones). Typecheck, i18n check and production build pass. Full upstream-baseline suite on Windows: 404 passed, 4 skipped, 10 failures in existing path/SQLite/child-process/CRLF portability checks; these are outside this three-file change. Tests do not invoke generation providers or alter project media.