Skip to content

Test iterable edge inputs in solid fillet and chamfer - #2107

Open
RanaPriyansh wants to merge 3 commits into
CadQuery:masterfrom
RanaPriyansh:test-iterable-edge-inputs-2104
Open

RanaPriyansh wants to merge 3 commits into
CadQuery:masterfrom
RanaPriyansh:test-iterable-edge-inputs-2104

Conversation

@RanaPriyansh

@RanaPriyansh RanaPriyansh commented Oct 8, 2026 •

Copy link
Copy Markdown

CadQuery's direct solid fillet and chamfer methods need regression coverage for iterable edge inputs. Add list and one-use generator cases for both methods, including asymmetric chamfer distances, independent volume checks, valid output geometry, and unchanged input solids. Preserve the upstream Shape-input cases.

The merged source 9cc9cf276b9af838fc3da453167bdbd2f4a82112, based on master 33361dc1b5b70bc83ce36f1b34a01ca85dfca80a, passed sequential Linux validation on GitHub Actions run 39437319607. The unchanged master baseline passed 900 tests and skipped three. The candidate passed 906 tests and skipped three. Both upstream Shape-input cases and all six iterable-input cases passed. Both phases passed the complete Black and Mypy checks and recorded 63 warnings. Their dependency inventories matched: 378 Conda packages and 110 pip distributions, with only the editable CadQuery path changed.

The earlier local macOS baseline volume failure in test_interpPlate remains documented. This Linux run does not resolve that separate limitation.

Codex used.

@adam-urbanczyk
adam-urbanczyk marked this pull request as draft October 8, 2026 21:40
@RanaPriyansh

Copy link
Copy Markdown
Author

Merged current master and completed fresh sequential Linux validation.
The baseline passed 898 tests, and the candidate passed 904 tests, with three skips in each phase.
All six added cases, full Black, and Mypy passed.

The macOS baseline still has the recorded test_interpPlate volume failure.
This PR remains a draft pending cross-platform validation and review.

Codex used.

@codecov

codecov Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.81%. Comparing base (33361dc) to head (9cc9cf2).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2107   +/-   ##
=======================================
  Coverage   95.81%   95.81%           
=======================================
  Files          30       30           
  Lines        9603     9603           
  Branches     1442     1442           
=======================================
  Hits         9201     9201           
  Misses        247      247           
  Partials      155      155           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RanaPriyansh
RanaPriyansh marked this pull request as ready for review October 15, 2026 09:44
@RanaPriyansh

Copy link
Copy Markdown
Author

Marked ready for review after upstream cross-platform validation.
The AppVeyor matrix passes all six added cases on Windows, Linux, and macOS.
Black, Mypy, and the complete suite pass on each platform.
The Azure Windows 3.13 build also passes.

Older Azure check record 116333678107 remains queued for the same successful build 6099.
Please reconcile that record if it is a required merge check.

Codex used.

@RanaPriyansh

Copy link
Copy Markdown
Author

The current master integration is now validated on GitHub Actions run 39437319607 for merged source 9cc9cf276b9af838fc3da453167bdbd2f4a82112. In the same sequential Linux environment, master passed 900 tests and the candidate passed 906. Both phases skipped three tests. Both upstream Shape-input cases and all six iterable-input cases passed in the candidate. Black and Mypy passed in both phases. Each phase recorded 63 warnings. The earlier local macOS baseline volume failure remains documented.

Codex used.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant