Repository navigation
fix(recording): keep each mixed Instant source at its own level - #2653
Closed
richiemcilroy wants to merge 1 commit into
Closed
richiemcilroy wants to merge 1 commit into
richiemcilroy wants to merge 1 commit into
Conversation
amix's default normalisation divided every input by the number of inputs, so with system audio on the microphone was recorded at half amplitude (-6 dB) while a microphone-only recording, which skips the mixer, was not. The mixer now sums its inputs at their own levels.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
Author
|
Closing: 0.6.0 mixes at the same levels (amix default normalisation), so this is not a regression, and mixing at full level did not change the macOS 15 marker damage it was tested against. Raising the voice level with system audio on can be a separate product decision (with a limiter, since the sum can clip). |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With system audio on, Instant recordings captured the microphone at half its amplitude (-6 dB). A microphone-only recording skips the mixer and kept full level, so turning system audio on made the voice quieter.
amixnormalises by default: every input is divided by the number of inputs, so a 0.5 microphone peak came out at 0.25 next to silent system audio.normalize=0each source keeps its own level and the mix is their sum.pcm_mixed_sources_keep_their_own_levelfeeds a 0.5 peak on each input and requires 0.5 out; it measures 0.25 on main.