Repository navigation
feat(app): demo voice message architecture (upstream #54426) - #3
ivanmilevtues wants to merge 1 commit into
Conversation
…nomalyco#54426) (cherry picked from commit bdf4793)
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 72 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
CodeBoarding reviewStatus: 3 changed components See the full change in CodeBoarding. graph LR
n_Client_Applications_and_Frontend_UI["Client Applications and Frontend UI"]
n_Core_Engine_and_Runtime["Core Engine and Runtime"]
n_Terminal_User_Interface_TUI_["Terminal User Interface #40;TUI#41;"]
n_AI_Provider_Integration["AI Provider Integration"]
n_CLI_and_Development_Commands["CLI and Development Commands"]
n_Server_and_Plugin_SDK["Server and Plugin SDK"]
n_Shared_Schemas_and_Types["Shared Schemas and Types"]
n_API_Protocol_and_Client_Contracts["API Protocol and Client Contracts"]
n_Infrastructure_and_Documentation_Services["Infrastructure and Documentation Services"]
n_Web_Sharing_Service["Web Sharing Service"]
n_Simulation_and_Mock_Services["Simulation and Mock Services"]
n_LaTeX_Engine["LaTeX Engine"]
n_Theme_and_Color_Specifications["Theme and Color Specifications"]
n_Functions_and_Testing_Utilities["Functions and Testing Utilities"]
n_Client_Applications_and_Frontend_UI -- "invokes utilities from" --> n_Core_Engine_and_Runtime
n_Client_Applications_and_Frontend_UI -- "uses types from" --> n_Shared_Schemas_and_Types
n_Client_Applications_and_Frontend_UI -- "configures proxy via" --> n_Server_and_Plugin_SDK
n_CLI_and_Development_Commands -- "renders via TUI components from" --> n_Terminal_User_Interface_TUI_
n_API_Protocol_and_Client_Contracts -- "binds schemas from" --> n_Shared_Schemas_and_Types
classDef added fill:#1f883d,stroke:#0b5d23,color:#ffffff;
classDef modified fill:#bf8700,stroke:#7d4e00,color:#ffffff;
classDef deleted fill:#cf222e,stroke:#82071e,color:#ffffff,stroke-dasharray:5 3;
class n_Client_Applications_and_Frontend_UI modified;
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 041a9c42af
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| presentation: (message) => { | ||
| const value = readPromptPresentation(message.metadata) | ||
| const parsed = value ? undefined : parseCommentNote(message.text) | ||
| const voice = parseVoiceDelegation(value?.displayText ?? message.text) |
There was a problem hiding this comment.
When an iOS voice follow-up arrives while the Session is busy, it can remain in SessionQueuePanel; that panel obtains its label through queuedPromptText (queue.ts:389-393), which returns the raw payload.text when the iOS message has no displayText metadata. Because voice parsing is applied only to delivered timeline rows here, the queued row exposes the full delegation header, JSON, and transcript instead of the framing or instruction until delivery. Apply the same presentation parsing to queued prompts.
AGENTS.md reference: AGENTS.md:L184-L184
Useful? React with 👍 / 👎.
1 participant
CodeBoarding demo — leave open
Faithful port of merged upstream anomalyco#54426 by opencode-agent[bot] (@app/opencode-agent), requested upstream by Brendan (@Brendonovich). This is demo material, not new original work or a request to merge.
Why this demo
Voice-delegation parsing feeds session timeline/message presentation and shared menus, icons, and localization across
app→session-ui→ui. A compact connected architecture change: 11 files, +263/−20, including parser tests and a Storybook fixture, without dependency or lockfile churn.Provenance and baseline
Original author and upstream commit reference preserved using
git cherry-pick -xfrom anomalyco@bdf4793. Rebased onto synceddevat 74afdf9 without source modifications. Upstream/replayed patch IDs match.Before opening this PR, verified successful licensed baseline sync: https://github.com/CodeBoarding/opencode2/actions/runs/38772657614. It committed
codeboarding/baselineand published the matching base artifact.Checks and limitations
bun run checkpasses: lint has warnings but no errors; 36/36 typecheck tasks pass.git diff --checkpasses; rebase leaves source tree unchanged.