London | 26-ITP-Sept | Hugh Mills | Sprint 2 | practice tdd by HM-127BTY · Pull Request #1697 · CodeYourFuture/Module-Structuring-and-Testing-Data

HM-127BTY · 2026-10-13T16:38:14Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Task code

CYF-1060

Changelist

Completed the tasks by doing tdd to the best of my ability.

…ing the task again and see I must not use .repeat.... here we go again then ^_^

hackertainment

Thank you for your coursework. Please keep it up.

hackertainment · 2026-10-19T14:53:03Z

Your code is correct. Just wondering what is the advantage of using this approach over other implementations? Thank you.

Of course from what I understand, its when its more test driven it helps you build the code as your making tests for it, it helps keep a better flow and streamlined work on the code while addressing the tests at the same time. If you just build the code itself without tests in this way it can lead to unseen issues that end up rebuild large chunks of the code that can result in making more bugs and issues.

Sorry maybe my original question was not clear. I didn't mean the advantages of TDD, I was wondering how would you come up with the following approach with the given test cases:

charMatch = str.match(new RegExp(char, "g"))

charMatch === null

return charMatch.length

Especially what is the advantage of such implementation but not other programming logics? Thank you for your claification.

I think it was when I was building up the code, I looked for something to use to count the "char" but i cant recall which i used but was only counting the first letter so when I searched for options on MDN i found .match() and used that one.

I found out about RegExp on the same page as .match() and saw it was used to help with finding the pattern of what i was searching for.

I still need to look into it more to understand it better to be honest.

If i think of it, this takes all the occurrences of g out of the string
For the null one I ran into an error that was showing null instead of 0 at the time so i think I put in an if to catch it out to show 0.

After finding those when I was stumped I couldn't think of any other logics I could have used at the time. I think i did it diffrently before so will look it up after this.

No worries, although the explanations are not quite accurate, at least I understand your thinking. Even this is not the best implementation, I would let you pass this one because the program runs correctly. Maybe try to book a mentored coding session with volunteer to try another way to solve the same exercise. Thank you.

p.s.: the g in new RegExp(char, "g") means "global search" but not searching for character "g".

hackertainment · 2026-10-19T14:55:14Z

 test("should count multiple occurrences of a character", () => {
  const str = "aaaaa";
  const char = "a";
  const count = countChar(str, char);
  expect(count).toEqual(5);
 });


This is a special case of str where it is all the char to count. Would it still count correctly if the char just exists in some part of the str?

yes, I forgot to do a test for that and have now put one in for that test of a random letters in a string.

hackertainment · 2026-10-19T14:55:48Z

+test("should count 0 with no occurrences of a character", () => {
+  const str = "aaaaa";
+  const char = "b";
+  const count = countChar(str, char);
+  expect(count).toEqual(0);
+});


There is a special str that would give 0 anyway. Please add that test case as well. Thank you.

Is that when str has nothing in it? I have added a test for this aswell as some others that have just thought of.

hackertainment · 2026-10-19T15:01:36Z

+  if (11 <= Number(numString.slice(-2)) && 19 >= Number(numString.slice(-2))) {
+    return numString + "th";
+  } else if (
+    -11 >= Number(numString.slice(-2)) &&
+    -19 <= Number(numString.slice(-2))
+  ) {


Please be aware of the consistency of code formatting - while the first if using one line for the conditions but the second if using multiple lines for the conditions. I personally would prefer one line which may usually be easier to read, unless explicitly specified by coding standard in a business environment.

I am aware of that, this is the doing of the auto format that we had to put into vscode. I tried to keep it like line 3 and it just automatically does that format, when I saw it doing that I tried to make it then be like lines 6 and 7 but then it forces it back to how it was at 3. Not sure how to stop it doing that when I hit tell it to save.

Thanks for letting me know. I will discuss with cirriculum team to improve the auto format file. All good for now.

hackertainment · 2026-10-19T15:03:14Z

Your test cases are correct. Just for you to think a little bit more, besides const str = "hello", what special string should also be added to each of the test cases?

Ah i think I understand, ones where it has a space or symbols, even an empty one. Added those tests.

Yes, sometimes space or symbols can be boundary cases. In the context of this program, only empty and non-empty string matters. Empty string with any positive or zero count should still be empty. However, empty string with negative count should still throw error. Some trainees also return empty string for negative count which would not be quite accurate "for the context of this question". This is why we need to test empty string "" together with "hello"in each of your original test suites - not adding empty string as a separate test suite. Since your program is correct, I will let you pass this time (even testing of empty string for count = -3 is missing) but understand the design process should be your focus. You may also book a mentored coding session with a volunteer to learn more about test cases design. Thank you.

Ah didn't think of the negatives there, need to remeber those. I see what you mean, I'll look into the mentored coding session I got coming up to ask about it but will look into it aswell.

hackertainment · 2026-10-22T10:07:50Z

Just remain this new comment #1697 (comment) , thank you.

hackertainment · 2026-10-22T19:58:19Z

Congratulation, you have completed this PR successfully.

HM-127BTY added 11 commits October 13, 2026 15:56

changed code in attempt to work for the test.. needs fixing.

e921f3c

Worked on code to ensure that if result is null it will show a 0

5dfa1de

Made it so code will show st for 1 at end of num

f920f8c

add th to numbers 11-19

33059ce

Added test for 2nd, and fixed th for numbers over 100

126b724

added tests for negative numbers and code for -11 to -19

e86b00a

corrected count using .repeat()

380ae27

added test for count of 1

c031244

added test for count of 0

7ad95cf

Added code and test to throw an error.. it is at this time I was read…

f3d3d7c

…ing the task again and see I must not use .repeat.... here we go again then ^_^

fixed the code to ensure no use of repeat was used by using "for"

f1b93ea

HM-127BTY added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 13, 2026

Fixxed errors in my toThrow

b15db6b

hackertainment added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 18, 2026

hackertainment mentioned this pull request Oct 18, 2026

Get Code Review and Iterate hackertainment/My-Coursework-Planner#8

Open

hackertainment reviewed Oct 19, 2026

View reviewed changes

hackertainment added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Oct 19, 2026

HM-127BTY added 2 commits October 21, 2026 12:45

Added multiple tests for the code.

c8ec84e

added more tests for repeat-str

641752b

HM-127BTY added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 21, 2026

hackertainment removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 22, 2026

HM-127BTY added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 22, 2026

Conversation

HM-127BTY commented Oct 13, 2026

Learners, PR Template

Task code

Changelist

Uh oh!

hackertainment left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hackertainment Oct 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hackertainment Oct 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hackertainment commented Oct 22, 2026

Uh oh!

hackertainment commented Oct 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hackertainment Oct 22, 2026 •

edited

Loading

hackertainment Oct 22, 2026 •

edited

Loading