Repository navigation
Conversation
abmhts
added
the
Needs Review
madhuranakate
suggested changes
Oct 21, 2026
| console.log(greetingStr); | ||
| } | ||
|
|
||
| testName = "Aman"; |
There was a problem hiding this comment.
Is this override necessary ? Could there be a better way to initialise this variable
Author
There was a problem hiding this comment.
Not necessary.
We can remove the redundant assignment and pass "Aman" directly to sayHello(), keeping the function flexible for any reasonable input.
| @@ -5,9 +5,7 @@ let testName = "Jerry"; | |||
| const greeting = "hello"; | |||
There was a problem hiding this comment.
does this variable name clash with another ?
Author
There was a problem hiding this comment.
No, it doesn't clash with another. The function parameter greeting is in a different scope. However, we can remove the outer variable and pass "hello" directly to sayHello().
madhuranakate
added
Reviewed
abmhts
added
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Task code
CYF-1066
Changelist
Refactored by removing unused, unreachable, and redundant code.