Repository navigation
Fix exact double recovery when printing numbers - #1099
Open
sergioperezcheco wants to merge 1 commit into
Open
sergioperezcheco wants to merge 1 commit into
sergioperezcheco wants to merge 1 commit into
Conversation
Assisted-by: Hermes Agent Signed-off-by: sergioperezcheco <checo520@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recovery check in
print_numberaccepts the 15-digit representation when it is only approximately equal to the original double. This can lose significant digits and even printDBL_MAXas a value that parses back as infinity.Use ordered comparisons to require exact numeric recovery before keeping the shorter representation, otherwise retain the existing 17-digit fallback. This avoids introducing another
-Wfloat-equalcomparison and leaves the public approximatecJSON_Comparebehavior unchanged. Regression tests cover the maximum finite values, numbers requiring additional significant digits, and public print/parse round trips.Fixes #838. Verified locally with the C89 strict build and all 22 CTest targets, plus an independent public API round-trip reproduction that fails on the original code and passes with this change. Windows/Linux and other locale/rounding-mode matrices were not run locally. Prepared with AI assistance and independently checked against the issue, source, and regression results.