Repository navigation
Conversation
parse_number passed any run of [0-9+-.eE] to strtod, so tokens such as 01, -01, 1., -.5 and 2.e3 were accepted even with require_null_terminated. Check the token against the RFC 8259 number grammar before converting it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse_number copies any run of [0-9+-.eE] into a temporary buffer and accepts whatever prefix strtod manages to convert, so
[01],[-01],[00],[1.],[-.5],[2.e3]and[0.e1]all parse, even through cJSON_ParseWithOpts with require_null_terminated set. These are the n_number_* JSONTestSuite cases from #877, and they leave cJSON accepting documents that RFC 8259 parsers reject (0123is read as decimal 123, where a lenient consumer may read it as octal). The token is now checked against the RFC 8259 number grammar before it reaches strtod, and the rejected forms are added to tests/parse_number.c.