Repository navigation
Run the docs deploy and release on Ubuntu 24.04 - #51
Merged
Merged
Conversation
ubuntu-latest is moving to Ubuntu 26.04, and ruby/setup-ruby only has the newest Ruby patch releases for it, not the 3.4.5 in .ruby-version. The docs deploy for e79b40f landed on 26.04 and failed to install Ruby. The Release workflow's Ruby jobs would fail the same way.
|
Warning Review limit reached
This review includes 2 billable files and costs up to $0.50.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 40 minutes for your next included review. View limit details
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs deploy for the #50 merge (e79b40f) failed before building anything:
Unavailable version 3.4.5 for ruby on ubuntu-26.04. GitHub is movingubuntu-latestfrom 24.04 to 26.04, and that run got 26.04; the deploy for #48 and the whole 0.3.0 Release workflow, two hours earlier, ran on 24.04. For Ubuntu 26.04, ruby-builder only has the newest patch releases (3.4.11, 3.3.12, 4.0.x), not the 3.4.5 in.ruby-version.This pins every job in
deploy-docs.ymlandrelease.ymltoubuntu-24.04, astest.ymlalready pinsubuntu-22.04. Without it, the Release workflow's Ruby jobs (building the gem, publishing it, syncing the provider) would fail at random in the same way.terraform-example.ymldoesn't install Ruby, so it stays onubuntu-latest.PR CI doesn't run these workflows: the deploy runs on pushes to
main, and the release on tags. The deploy after this merges is the first real check.task cipasses locally.