Repository navigation
Conversation
junit-jupiter-engine was compile-scoped in estore, so JUnit 5 leaked into every consumer, including estore-maven-plugin. Scope it to test. estore-maven-plugin has no tests, so its maven-compat, junit 4.12 and maven-plugin-testing-harness test dependencies are unused; remove them. antlr4-runtime and javaparser-symbol-solver-core stay because CodegenMojo imports them directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #11, as requested in review.
Changes
estore/pom.xml:junit-jupiter-engineis now test-scoped. It was compile-scoped, so JUnit 5 leaked into every consumer ofestore, includingestore-maven-plugin.estore-maven-plugin/pom.xml: removes three unused test dependencies:maven-compat,junit4.12 andmaven-plugin-testing-harness. The plugin has no tests onmain.Testing
Ran locally:
mvn -pl estore clean test jacoco:report jacoco:checkpasses (225 tests, coverage gate met), the plugin installs, andmvn spotless:checkis clean.🤖 Generated with Claude Code using Claude Opus 5.5 (
claude-opus-5-5)