Repository navigation
Fixed bug #9070 : Access violation crashes server when a partial (conditional) index with a complex predicate is present on a table under DML load - #9178
Merged
Conversation
…ditional) index with a complex predicate is present on a table under DML load
dyemanov
reviewed
Oct 18, 2026
| auto* node = static_cast<BoolExprNode*>(csb->csb_node); | ||
|
|
||
| Optimizer opt(tdbb, csb); | ||
| node = opt.transformBoolExpr(tdbb, node); |
Member
There was a problem hiding this comment.
I fail to see the need to create an optimizer instance, as transformBoolExpr() does not seem to use any its state except csb and pool. This looks like unnecessary complication. Instead, transformBoolExpr() could be a module-static routine or even a lambda inside Optimizer::transformBoolean().
Co-authored-by: Dmitry Yemanov <dyemanov@users.noreply.github.com>
dyemanov
reviewed
Oct 18, 2026
| conjuncts(getPool()) | ||
| { | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
AFAIU, the new constructor is no longer needed.
Member
Author
There was a problem hiding this comment.
Sure, forgot to remove it.
Btw, is it correct to use csb_pool in transformBoolean() or better to use default pool (as in Optimizer() ctor) ?
Member
There was a problem hiding this comment.
During pass1/pass2 (optimization belongs to the latter) it's the same pool, AFAIR. So use whatever you like.
dyemanov
approved these changes
Oct 18, 2026
hvlad
added a commit
that referenced
this pull request
Oct 19, 2026
Fixed bug #9070 : Access violation crashes server when a partial (conditional) index with a complex predicate is present on a table under DML load
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem happens when
Retrieval::checkIndexCondition()callsoptimizer->decomposeBoolean(idx.idx_condition)and injects new nodes intoidx_conditiontree (seeblr_orhandling branch). That new nodes created in current request pool. Preparing of next request after release of first one accesses deallocated memory and crashes the server.