Repository navigation
Update verify_attestation_chains with new manufacturer cert - #14650
Merged
Merged
Conversation
The certificate expired and a new certificate to the same key now exists. Update the script to point to the new certificate instead of the expired certificate.
product-auto-label
Bot
added
samples
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the manufacturer certificate URL and the certificate filename inside the downloaded ZIP archive. The review feedback suggests loading the manufacturer certificate URL from an environment variable to avoid runtime failures due to placeholder values, and dynamically searching for the .crt file inside the ZIP archive instead of hardcoding the filename to improve robustness.
iennae
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The certificate expired and a new certificate to the same key now exists.
Update the script to point to the new certificate instead of the expired certificate.
Description
Checklist
Testing
Compliance & Style
Post-Approval Actions