Repository navigation
Add conservative Teams-aware reverse futility pruning - #40
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shallow non-PV Teams nodes currently search even when their static team evaluation exceeds beta by a large margin. Add conservative reverse futility pruning on current main (
9b40200) without importing the old RFP branch's unrelated merge history. Supersedes #28; its complete tip (dcefe70) is preserved asarchive/rfp-pr-28.RFP runs after TT/mate-distance cutoffs and before NMP. At depths 1–4 it returns
staticEval - 200 * depthwhen that estimate reaches beta. It retains the moving team's score perspective for all four seats, records raw evaluation on the current search stack, and reuses it for NMP without changing NMP's policy.Guards exclude root/PV nodes, null-move child nodes, mate windows/scores, either allied king in check, and movers without non-pawn material. Candidate cutoffs also require all four players/kings, no checked enemy king or terminal king capture, no pawn one step from promotion in any orientation, and at least two legal moves. This preserves immediate terminal scores, stalemate, forced moves, partner threats and promotion handling. The cutoff does not store an exact TT result or invent a best move.
Validation:
getenvdeprecation warning in main.cpp remains.git diff --checkpassed.The safety checks add candidate-cutoff overhead and RFP remains a selective heuristic. No Elo gain is claimed. Paired fixed-node/fixed-time games and a predeclared SPRT against the same main revision are still needed before strength claims or more aggressive tuning. See docs/reverse-futility-pruning.md for placement, Teams semantics, initial settings, risks and testing guidance.