Skip to content

test: standardize PHPUnit test naming - #9166

Merged
vitormattos merged 2 commits into
LibreSign:mainfrom
GabrielPdoCarmo:refactor/issue-9146-phpunit-names
Oct 23, 2026
Merged

vitormattos merged 2 commits into
LibreSign:mainfrom
GabrielPdoCarmo:refactor/issue-9146-phpunit-names

Conversation

@GabrielPdoCarmo

Copy link
Copy Markdown
Contributor

Summary

Closes #9146.

Standardizes PHPUnit test names to match their corresponding production classes.

Changes

  • Rename CrlMapperDbTest to CrlMapperTest.
  • Rename FolderServiceDbTest to FolderServiceTest.
  • Split BackgroundJobsRegistrationTest into SignFileJobTest and SignSingleFileJobTest.
  • Update AGENTS.md with PHPUnit naming conventions.

Validation

  • PHP syntax checks passed.
  • PHP-CS-Fixer checks passed for all four affected test files.
  • Integration tests passed in the Nextcloud Dev Container:
    • SignFileJobTest: 1 test, 3 assertions
    • SignSingleFileJobTest: 1 test, 3 assertions
    • CrlMapperTest: 3 tests, 3 assertions
    • FolderServiceTest: 1 test, 3 assertions

Total: 6 tests, 12 assertions, all passing.

The corresponding Developer Manual documentation update is submitted separately.

Signed-off-by: Gabriel Pereira do Carmo <gabrielcarmobr14@gmail.com>
@GabrielPdoCarmo
GabrielPdoCarmo requested a review from a team as a code owner October 22, 2026 22:24
@welcome

welcome Bot commented Oct 22, 2026

Copy link
Copy Markdown

Thanks for opening your first pull request in this repository! ✌️

Comment thread AGENTS.md Outdated
Signed-off-by: Gabriel Pereira do Carmo <gabrielcarmobr14@gmail.com>
@vitormattos
vitormattos merged commit 7eb69c5 into LibreSign:main Oct 23, 2026
58 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Hi @GabrielPdoCarmo, your first pull request to LibreSign has been merged. 🎉

Your work is part of LibreSign now, and everyone who signs a document with it benefits from the time and knowledge you shared. Thank you.

You are very welcome to contribute again. The good first issue list is a good place to look next, and you no longer have to wonder how the process works.

If you have a few minutes and feel like it, we would love to hear how this went for you: https://ls.librecode.coop/index.php/645932?lang=en&source=github-first-merged-pr&repository=libresign. It is entirely optional; nothing is expected of you in return for contributing.

Come say hello in the LibreSign community: https://t.me/LibreSign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Standardize PHPUnit test names to match source classes

2 participants