Skip to content

Fix pandas inplace deprecation #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cbrnr wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix pandas inplace deprecation #576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion wfdb/io/_header.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ def get_write_subset(self, spec_type):

# Remove the n_seg requirement for single segment items
if not hasattr(self, "n_seg"):
record_specs.drop("n_seg", inplace=True)
record_specs = record_specs.drop("n_seg")

for field in record_specs.index[-1::-1]:
# Continue if the field has already been included
Expand Down
29 changes: 15 additions & 14 deletions wfdb/io/annotation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -725,8 +725,8 @@ def standardize_custom_labels(self):
:n_custom_labels
]

custom_labels.set_index(
custom_labels["label_store"].values, inplace=True
custom_labels = custom_labels.set_index(
custom_labels["label_store"].values
)
custom_labels = custom_labels[list(ann_label_fields)]

Expand Down Expand Up @@ -1322,8 +1322,8 @@ def get_contained_labels(self, inplace=True):
custom_labels = label_triplets_to_df(self.custom_labels)
elif isinstance(self.custom_labels, pd.DataFrame):
# Set the index just in case it doesn't already match the label_store
self.custom_labels.set_index(
self.custom_labels["label_store"].values, inplace=True
self.custom_labels = self.custom_labels.set_index(
self.custom_labels["label_store"].values
)
custom_labels = self.custom_labels
else:
Expand All @@ -1344,12 +1344,12 @@ def get_contained_labels(self, inplace=True):
counts = np.unique(self.label_store, return_counts=True)
elif self.symbol is not None:
index_vals = set(self.symbol)
label_map.set_index(label_map["symbol"].values, inplace=True)
label_map = label_map.set_index(label_map["symbol"].values)
reset_index = True
counts = np.unique(self.symbol, return_counts=True)
elif self.description is not None:
index_vals = set(self.description)
label_map.set_index(label_map["description"].values, inplace=True)
label_map = label_map.set_index(label_map["description"].values)
reset_index = True
counts = np.unique(self.description, return_counts=True)
else:
Expand All @@ -1365,8 +1365,8 @@ def get_contained_labels(self, inplace=True):
)

if reset_index:
contained_labels.set_index(
contained_labels["label_store"].values, inplace=True
contained_labels = contained_labels.set_index(
contained_labels["label_store"].values
)

if inplace:
Expand Down Expand Up @@ -1469,8 +1469,8 @@ def convert_label_attribute(
return

label_map = self.create_label_map(inplace=False)
label_map.set_index(
keys=pd.Index(label_map[source_field].values), inplace=True
label_map = label_map.set_index(
keys=pd.Index(label_map[source_field].values)
)

try:
Expand Down Expand Up @@ -1515,7 +1515,7 @@ def label_triplets_to_df(triplets):
}
)

label_df.set_index(label_df["label_store"].values, inplace=True)
label_df = label_df.set_index(label_df["label_store"].values)
label_df = label_df[list(ann_label_fields)]

return label_df
Expand Down Expand Up @@ -3059,9 +3059,8 @@ def __init__(self, extension, description, human_reviewed):
"human_reviewed": [ac.human_reviewed for ac in ann_classes],
}
)
ann_class_table.set_index(
ann_class_table = ann_class_table.set_index(
keys=pd.Index(ann_class_table["extension"].values),
inplace=True,
)
ann_class_table = ann_class_table[
["extension", "description", "human_reviewed"]
Expand Down Expand Up @@ -3229,5 +3228,7 @@ def __str__(self):
"description": [al.description for al in ann_labels],
}
)
ann_label_table.set_index(ann_label_table["label_store"].values, inplace=True)
ann_label_table = ann_label_table.set_index(
ann_label_table["label_store"].values
)
ann_label_table = ann_label_table[["label_store", "symbol", "description"]]
Loading