Repository navigation
Remove temporary directories in cull() and convert() - #771
Merged
Merged
Conversation
Both functions created a working directory with mkdtemp() and never removed it, leaving copies of the input mesh, masks and output mesh behind on every call, despite their docstrings saying temporary files are deleted. Use TemporaryDirectory, as mask() already does, closing the loaded output dataset and copying any graph file before the directory is removed. Add a test that the working directory only contains the requested graph files after culling and converting a mesh. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Collaborator
Author
Testingmpas_tools 2.2.0 isn't on conda-forge yet, so I tested in a conda environment with the mpas_tools 2.1.0 package (for the compiled executables) and this branch installed in editable mode on top.
Posted by Claude Code on @xylar's behalf. The testing, analysis and wording above are AI-authored; please check them accordingly. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cull()andconvert()inmpas_tools.mesh.conversioncreated their working directory withmkdtemp()and never removed it, so every call left copies of the input mesh, masks and output mesh behind (in the current directory whendir='.'is passed, as Polaris does). This PR usesTemporaryDirectory, asmask()already does, closing the loaded output dataset and copying anygraph.infofile before the directory is removed. It also adds a test that only the requested graph files remain indirafter culling and converting a planar mesh.Fixes #764
Posted by Claude Code on @xylar's behalf. The testing, analysis and wording above are AI-authored; please check them accordingly.
🤖 Generated with Claude Code