Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A form feed inside a quoted attribute currently ends the value early, dropping its remaining text and potentially treating it as additional attributes. For example, the
altvalue in<img alt="before\f after" src="foo.png">is truncated.Remove form feed from the quoted-value stop characters, as required by the HTML tokenization rules. Unquoted attributes still treat it as a separator. Tests exercise single and double quotes, character references, subsequent attributes, full documents, fragments, and serialization/reparsing.
Fixes #280.
Validation: PHP 8.5.4 / PHPUnit 10.5.66, 169 tests and 2,162 assertions pass. The regression fails before the change. The three PHPUnit data-provider deprecations also occur on the clean base. PHP CS Fixer 2.19.3 reports only the same existing by-reference spacing changes on base and patch; other PHP versions were not run locally.