Repository navigation
test: enforce network-controller source type checks - #11031
Open
cryptodev-2s wants to merge 1 commit into
Open
cryptodev-2s wants to merge 1 commit into
cryptodev-2s wants to merge 1 commit into
Conversation
cryptodev-2s
added this pull request to stack #11032
October 23, 2026 09:41
cryptodev-2s
force-pushed
the
test/network-controller-typecheck
branch
from
October 23, 2026 17:17
c508725 to
518c466
Compare
cryptodev-2s
force-pushed
the
test/network-controller-typecheck
branch
from
October 23, 2026 17:37
518c466 to
861ff48
Compare
Use a non-composite test tsconfig and explicitly select the declared native TypeScript compiler. Fix stale test-helper arguments, the expected-error directive, and the registry annotation, then remove the 21 obsolete TSC suppressions.
cryptodev-2s
force-pushed
the
test/network-controller-typecheck
branch
from
October 23, 2026 20:06
861ff48 to
d0cb7ea
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Stacked on #10873. Remove
ignoreSourceErrorsfrom network-controller's Vitest configuration so source diagnostics also fail the test command.Use a non-composite test tsconfig without project references and explicitly select the declared
@typescript/nativecompiler.skipLibCheckfollows the repository's existing build/lint policy for dependency declarations.Remove obsolete clock arguments, move an expected-error directive to the invalid property, and give the mixed client registry its existing union type in the test. Remove the 21 TSC suppressions these fixes make unnecessary.
Validation
@ts-expect-errorand a source-only type error each fail type checking. All temporary mutations were restored.yarn install --immutablepasses.References
Checklist
Note
Low Risk
Changes are limited to test tooling configuration and test-only type fixes; no production runtime behavior is modified.
Overview
Enforces real TypeScript checking on
network-controllertests instead of ignoring source errors during Vitest typecheck.Vitest now runs the native
@typescript/nativechecker against a newtsconfig.test.json(non-composite,noEmit,skipLibCheck, no project references). Related entries are removed fromtsc-suppressions.json.Test fixes so the suite typechecks cleanly: explicit typing for
getNetworkClientRegistry()inNetworkController.test.ts, repositioned@ts-expect-erroron the intentional bad RPC payload inrpc-service.test.ts, and dropped obsoleteclockarguments towaitForPromiseToBeFulfilledAfterRunningAllTimersin shared network-client test helpers.Reviewed by Cursor Bugbot for commit c508725. Bugbot is set up for automated code reviews on this repo. Configure here.