Repository navigation
feat: add volume totals to social feed actors and leaderboard - #11042
Merged
Merged
Conversation
Accept optional volumeUsd30d and volumeUsd7d on feed actors and leaderboard entries, and map both from profile metadata when normalizing realtime feed events. Co-authored-by: João Santos <joaosantos15@users.noreply.github.com>
Co-authored-by: João Santos <joaosantos15@users.noreply.github.com>
joaosantos15
enabled auto-merge
October 23, 2026 20:24
souterjk
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Social-api now returns 30-day and 7-day USD volume on feed actors and leaderboard entries (consensys-vertical-apps/va-mmcx-social-api#448).
@metamask/social-controllersdropped those fields because the response structs did not declare them.FeedActorSummaryaccepts optionalvolumeUsd30dandvolumeUsd7d. These are all-chain totals from hydrated profile metadata. Realtime feed normalization reads both keys fromactor.profile.metadatathe same way it already reads PnL and win rate. Missing metadata becomesnull.LeaderboardEntryaccepts the same optional fields. Chain scoping stays on social-api: when the leaderboard query includeschains, the values are the sum ofperChainVolumeUsd30d/perChainVolumeUsd7dfor those chains; otherwise they are the global metadata totals. Older responses that omit the keys still validate.References
Checklist
Slack Thread
Note
Low Risk
Additive optional types and validation only; no behavior changes beyond preserving new API fields on parse.
Reviewed by Cursor Bugbot for commit 21f1ebf. Bugbot is set up for automated code reviews on this repo. Configure here.