Skip to content

feat: add volume totals to social feed actors and leaderboard - #11042

Merged
joaosantos15 merged 2 commits into
mainfrom
social-ai-cursor-social-volume-fields-075f
Oct 23, 2026
Merged

joaosantos15 merged 2 commits into
mainfrom
social-ai-cursor-social-volume-fields-075f

Conversation

@joaosantos15

@joaosantos15 joaosantos15 commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Explanation

Social-api now returns 30-day and 7-day USD volume on feed actors and leaderboard entries (consensys-vertical-apps/va-mmcx-social-api#448). @metamask/social-controllers dropped those fields because the response structs did not declare them.

  • FeedActorSummary accepts optional volumeUsd30d and volumeUsd7d. These are all-chain totals from hydrated profile metadata. Realtime feed normalization reads both keys from actor.profile.metadata the same way it already reads PnL and win rate. Missing metadata becomes null.
  • LeaderboardEntry accepts the same optional fields. Chain scoping stays on social-api: when the leaderboard query includes chains, the values are the sum of perChainVolumeUsd30d / perChainVolumeUsd7d for those chains; otherwise they are the global metadata totals. Older responses that omit the keys still validate.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Slack Thread

Open in Web Open in Cursor 

Note

Low Risk
Additive optional types and validation only; no behavior changes beyond preserving new API fields on parse.

Reviewed by Cursor Bugbot for commit 21f1ebf. Bugbot is set up for automated code reviews on this repo. Configure here.

Accept optional volumeUsd30d and volumeUsd7d on feed actors and
leaderboard entries, and map both from profile metadata when
normalizing realtime feed events.

Co-authored-by: João Santos <joaosantos15@users.noreply.github.com>
@joaosantos15
joaosantos15 requested review from a team as code owners October 23, 2026 17:18
@joaosantos15
joaosantos15 deployed to default-branch October 23, 2026 17:18 — with GitHub Actions Active
Co-authored-by: João Santos <joaosantos15@users.noreply.github.com>
@joaosantos15
joaosantos15 added this pull request to the merge queue Oct 23, 2026
Merged via the queue into main with commit e2bcb1a Oct 23, 2026
46 checks passed
@joaosantos15
joaosantos15 deleted the social-ai-cursor-social-volume-fields-075f branch October 23, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants