Repository navigation
Log the local error of failed node operations - #801
Merged
Merged
Conversation
A failed sandbox node operation logged only its wire error code, so a node whose service account could not open the workspace storage root logged error_code=unconfirmed for every create and nothing else. The node now keeps the local error in its journal, as generation readiness failures already do; only the code crosses the transport.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Found in the mx acceptance on main 9a663ff. A microsandbox node whose
oac-nodeaccount had the wrong UID for the NFS workspace storage failed everycreate, and its journal showed only:Core logged
managed Runtime bootstrap incomplete, and the Session failed withFailed to provision environment: initialization did not complete. Nothing on either side named the cause (permission deniedopening the storage root).Change
executealso returns the local error, and the node's operation log adds it aserrorwhen an operation fails. As with generation readiness failures, the text stays in the host's journal (it may name host paths); only the error code crosses the node transport, which is unchanged.Checks
go test ./services/core/internal/sandbox/node/go vet ./services/core/...Need help on this PR? Tag
@codesmith-botwith what you need.