Skip to content

CSTACKEX-337: fixing the bug for First VM deployment double-counts template size #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sathvikaragi merged 5 commits into from
Oct 19, 2026
Merged

CSTACKEX-337: fixing the bug for First VM deployment double-counts template size #125

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ab9fd56
CSTACKEX-337: fixing the bug for First VM deployment double-counts th…
sathvikaragi Oct 15, 2026
0931fa2
CSTACKEX-337: adding a comment for getallocatedpoolcapacity regarding…
sathvikaragi Oct 19, 2026
c669b74
CSTACKEX-337: adding a comment for getallocatedpoolcapacity regarding…
sathvikaragi Oct 19, 2026
605464f
CSTACKEX-337: adding a comment for getallocatedpoolcapacity regarding…
sathvikaragi Oct 19, 2026
e3e3612
CSTACKEX-337: trailing space
sathvikaragi Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions server/src/main/java/com/cloud/capacity/CapacityManagerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,25 +573,16 @@ public long getUsedIops(StoragePoolVO pool) {
throw new CloudRuntimeException("Storage driver in CapacityManagerImpl.getUsedIops(StoragePoolVO) is not a PrimaryDataStoreDriver.");
}

//Managed pool, return value contains used size of the pool.
//Unmanaged pool, return value contains used pool size and template size.
@Override
public long getAllocatedPoolCapacity(StoragePoolVO pool, VMTemplateVO templateForVmCreation) {
long totalAllocatedSize;

// if the storage pool is managed, the used bytes can be larger than the sum of the sizes of all of the non-destroyed volumes
// in this case, call getUsedBytes(StoragePoolVO)
if (pool.isManaged()) {
totalAllocatedSize = getUsedBytes(pool);

if (templateForVmCreation != null) {
VMTemplateStoragePoolVO templatePoolVO = _templatePoolDao.findByPoolTemplate(pool.getId(), templateForVmCreation.getId(), null);
if (templatePoolVO == null) {
// template is not installed in the pool, consider the template size for allocation
long templateForVmCreationSize = templateForVmCreation.getSize() != null ? templateForVmCreation.getSize() : 0;
totalAllocatedSize += templateForVmCreationSize;
}
}

return totalAllocatedSize;
return getUsedBytes(pool);

@suryag1201 suryag1201 Oct 16, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adaptive breaks because it is managed storage and creates a real template copy on the array but its overriding method returns 0. So the template size will not get added for them

@sathvikaragi sathvikaragi Oct 16, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, There are vendors who return getBytesRequiredForTemplate 0 which is called in getAskingSizeForTemplateBasedOnClusterAndStoragePool. But From the cloudstack perspective They are expected to implement these methods to provide their template size. Template size shouldn't be part of allocated size calculation as keeping it here will lead to double counting of template size for all vendors who have implemented getBytesRequiredForTemplate in driver.

} else {
// Get size for all the non-destroyed volumes.
Pair<Long, Long> sizes = _volumeDao.getNonDestroyedCountAndTotalByPool(pool.getId());
Expand Down
Loading