Skip to content

BaseRawIO: fix the has_buffer_description_api() check in get_analogsignal_buffer_description #1930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cboulay wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −1
Open

BaseRawIO: fix the has_buffer_description_api() check in get_analogsignal_buffer_description #1930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion neo/rawio/baserawio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1544,7 +1544,7 @@ def _rescale_epoch_duration(self, raw_duration: np.ndarray, dtype: np.dtype):
# buffer api zone
# must be implemented if has_buffer_description_api=True
def get_analogsignal_buffer_description(self, block_index: int = 0, seg_index: int = 0, buffer_id: str = None):
if not self.has_buffer_description_api:
if not self.has_buffer_description_api():
raise ValueError("This reader do not support buffer_description API")
descr = self._get_analogsignal_buffer_description(block_index, seg_index, buffer_id)
return descr
Expand Down
7 changes: 7 additions & 0 deletions neo/test/rawiotest/test_examplerawio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,13 @@ class TestExampleRawIO(
# name here instead of the filename.
entities_to_test = ["fake1"]

def test_buffer_description_api_check(self):
"""An ExampleRawIO reader, whose flag is False, must raise ValueError."""
reader = ExampleRawIO(filename=self.get_local_path("fake1"))
reader.parse_header()
with self.assertRaises(ValueError):
reader.get_analogsignal_buffer_description(block_index=0, seg_index=0, buffer_id="0")


if __name__ == "__main__":
unittest.main()
Loading