Repository navigation
Guide campaign intake and continuation from existing work - #69
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
developer-docs | 867ec2a | Commit Preview URL Branch Preview URL |
Oct 23 2026, 05:28 AM |
Code Review SummaryStatus: 4 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (4 files changed since 8746699)
Resolved since last review
Notes
Fix these issues in Kilo Cloud Previous Review Summaries (6 snapshots, latest commit 8746699)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 8746699)Status: 3 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (2 files changed since 3a7355a)
Resolved since last review
Notes
Fix these issues in Kilo Cloud Previous review (commit 3a7355a)Status: 4 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (9 files)
Resolved since last review
Notes
Fix these issues in Kilo Cloud Previous review (commit c9ec24a)Status: 3 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (4 files)
Resolved since last review
Fix these issues in Kilo Cloud Previous review (commit e910dae)Status: 3 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (3 files)
Resolved since last review
Fix these issues in Kilo Cloud Previous review (commit 4d77a1b)Status: 3 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (4 files)
Notes on scopeIncremental commits Previously reported findings and their status. The three findings from the prior summary were all resolved in Drift checks verified against current source. Cross-page consistency. The Assumptions / validation gaps. Fix these issues in Kilo Cloud Previous review (commit 7ec6918)Status: 3 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (2 files)
Notes on scopeIncremental commits All previously reported findings are resolved. The Anchor and link integrity verified. Both new cross-page links resolve: Drift checks unaffected. Previously carried-forward follow-up is now fixed. The hardcoded Assumptions / validation gaps: [Snapshot truncated.] Additional previous summary content was truncated to keep this comment within platform limits. Reviewed by minimax-m3 · Input: 48K · Output: 4K · Cached: 377.8K |
A no-key Page Kit scaffold is inert at the source: init clears the template demo key and the Campaign Cart SDK does not boot without one. Remove the hand-authored concept directory, its CSP and the 0.3.0 caveats, and describe the unconfigured preview in one paragraph. Keep the entry-point table, existing-build inspection, connection steps and the continuation handoff.
No commerce calls and no dl_* events, with the locale fetch named; on 0.3.0 clear apiKey by hand; vendor keys in campaigns.json load without the SDK key.
…time_mode No commerce calls and no SDK analytics events; vendor snippets loaded from campaigns.json keys do not depend on the SDK key, so an unconfigured campaign keeps them empty. Confirm runtime_mode before npm run dev. Configured examples fail on an unset CAMPAIGN_API_KEY instead of passing an empty value.
The starter templates ship with an empty apiKey (campaign-cart-starter- templates#245), so the no-key preview no longer depends on a Page Kit version or on init reporting runtime_mode.
Drop the inspection-directory install block in favour of the Campaigns OS quick start, the installed-version section, and the --no-install repetition (one sentence remains in the Page Kit guide). Tighten each section; the preview paragraph no longer asks an agent to edit an existing slug's tracking.
…o-install sentence
Starter templates keep their demo key (campaign-cart-starter-templates#245 closed on Sam's review). The guide and both campaign pages now say a scaffold without a key is demo-bound: fine for layout review, not evidence.
The campaign quickstart assumed a new Page Kit project and left URL intake, existing builds and session handoffs implicit. This extends the guide to cover those entry points, preserve build and hosting choices, and describe the local preview before commerce is connected: a scaffold made without a campaign key runs against the starter templates' demo campaign, which is fine for reviewing layout and flow and is not evidence about the merchant's campaign.
Earlier revisions carried a hand-authored static-concept procedure, a Page Kit release gate, and an empty-key template premise, each a workaround for the demo key. All three went once the harm was named correctly: demo-bound pages must not be accepted as proof, which is tracked in NextCommerceCo/campaigns-os#701.
Validation: production build and documentation checks pass. No merge gate. Companion: NextCommerceCo/skills#88, which merges after this.