Skip to content

Point account sign-in links at accounts.nextcommerce.com - #74

Open
next-devin wants to merge 2 commits into
mainfrom
accounts-domain-scrub
Open

next-devin wants to merge 2 commits into
mainfrom
accounts-domain-scrub

Conversation

@next-devin

@next-devin next-devin commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

accounts.nextcommerce.com now serves every Nexus account user, so the merchant docs stop pointing people at accounts.29next.com.

  • The links for sign-in, user profiles, multiple stores, NEXT Payments, APMs and partner marketing reports now go to accounts.nextcommerce.com. Each path redirects to the new host's own login page, just as it did on the old host.
  • The "Why 29next?" callout and /llms.txt no longer list the accounts host as a legacy identifier.

Left as they are on purpose:

  • content/changelog/2025-02-19-…mdx is release history.
  • scripts/fix-changelog-urls.mjs restores historical changelog text.

validate-links and check-markup pass locally.

Merge order: merge NextCommerceCo/developer-docs#70 first. lib/capabilities.snapshot.json carries only the legacy-identifiers record (summary and last_verified) from #70's preview map, so /llms.txt and the snapshot agree. Once #70 is live, npm run sync-capabilities regenerates that record as is. Running a sync before then would bring back the old text.

accounts.nextcommerce.com now serves every Nexus account user. Sign-in,
user-profile, payments and partner-report links move there, and the
legacy identifiers notice no longer lists the accounts host.
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
nextcommerce-docs bb76366 Commit Preview URL

Branch Preview URL
Oct 23 2026, 02:26 AM

Comment thread app/llms.txt/route.ts
Comment thread content/docs/start-here/get-started/invite-team-members.mdx
@kilo-code-bot

kilo-code-bot Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Code Review Summary

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
lib/capabilities.snapshot.json 1658 The generated snapshot is hand-patched, so it is no longer reproducible by npm run sync-capabilities. generated_at still reads 2026-09-04 while the record now claims last_verified: 2026-10-23, and the next sync from the published map (which does not yet carry developer-docs#70) will silently revert the fix and reintroduce the /llms.txt vs capabilities.json contradiction. No check covers this.
Files Reviewed (1 file changed since previous review)
  • lib/capabilities.snapshot.json - 1 issue
Resolution of prior findings
  • app/llms.txt/route.ts:27 — resolved. The legacy-identifiers record no longer contains accounts.29next.com; a repo-wide search of lib/ and app/ returns only {store}.29next.store, the X-29next-API-Version / X-29Next-Signature headers, and the remaining "never rewrite 29next identifiers" note, all of which are consistent with the llms.txt prose. /llms.txt and the snapshot no longer disagree.
  • content/docs/start-here/get-started/invite-team-members.mdx:23 — resolved. The link is unchanged, and the author verified against the live host that /users/~update/ returns 302 to /accounts/login/?next=/users/~update/ while unknown paths 404, so the route exists and is auth-gated.
Verification notes
  • Incremental diff is a single commit (bb76366) touching one file with two changed lines; no other files were re-analyzed.
  • Confirmed both new-comment targets resolve to RIGHT-side diff lines (hunks @@ -1642,7 +1642,7 @@ → line 1645, @@ -1655,7 +1655,7 @@ → line 1658).
  • sync-capabilities.mjs overwrites the entire snapshot with JSON.stringify(map, null, 2) and performs no merge, which is the basis for the revert risk.
  • check-capabilities.mjs validates only the last_verified format in page frontmatter and never cross-checks generated_at, so CI will not catch either the inconsistency or a future silent revert.
  • Checked whether the edited summary reaches end users: components/developer-resources.tsx reads only sources and the id/title/audiences/operator_docs/developer_docs fields, so the capability summary is agent-facing only. The finding is scoped to agent-facing output and to snapshot integrity, not to merchant-visible UI.
  • validate-links, check-markup, and check-capabilities were not executed (read-only, non-interactive session); script sources were read instead.
  • .claude/rules contains no rules files, so no additional domain guidance applied.

Fix these issues in Kilo Cloud

Previous Review Summary (commit 1561742)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 1561742)

Status: 2 Issues Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 2
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
app/llms.txt/route.ts 27 Legacy-identifier list now contradicts the published capability map, which still declares accounts.29next.com a live 29 Next identifier that agents must not rewrite. /llms.txt and the capabilities.json it links now give agents opposite answers on the same host until the developer-docs snapshot PR lands.
content/docs/start-here/get-started/invite-team-members.mdx 23 Deep /users/~update/ path is carried over to the new host unverified. Host roots redirect transparently, but an app route may 404 or drop to a bare login; validate-links does not crawl external hosts, so this is not covered by the checks cited in the PR description.
Files Reviewed (8 files)
  • app/llms.txt/route.ts - 1 issue
  • content/docs/analytics/partner-marketing-reports.mdx - 0 issues
  • content/docs/features/payments/gateways/next-payments.mdx - 0 issues
  • content/docs/features/payments/index.mdx - 0 issues
  • content/docs/features/payments/stripe-apms.mdx - 0 issues
  • content/docs/start-here/get-started/index.mdx - 0 issues
  • content/docs/start-here/get-started/invite-team-members.mdx - 1 issue
  • content/docs/start-here/multiple-stores.mdx - 0 issues
Verification notes
  • Domain swap is mechanically consistent: after this change, accounts.nextcommerce.com appears in all 10 intended locations and no accounts.29next.com remains in content/docs or app/.
  • Remaining 29next.com hits were verified as intentionally out of scope per the PR description: content/changelog/2025-02-19-checkout-subscriptions-payments-storefront.mdx (release history), scripts/fix-changelog-urls.mjs:147 (restores historical changelog prose; unchanged by this PR), lib/capabilities.snapshot.json:1645 (generated, cross-repo — this is the substance of the app/llms.txt/route.ts:27 finding), and scripts/audit-developer-links.mjs:9 (developer-host audit list).
  • git grep across redirects/ shows the only host-redirect worker in this repo is changelog-legacy; there is no in-repo redirect layer covering accounts.*, so the path behaviour in the second finding cannot be confirmed from this repository and must be checked against the live host.
  • The stated "Why 29next?" callout removal was checked for internal consistency: with the account host removed, the remaining list (store hostnames, API headers, API key namespace) is coherent and no dangling reference to the dropped host remains.
  • .claude/rules was checked as instructed by the custom instructions; the directory contains no rules files (only .claude/skills/changelog/SKILL.md), so no domain-specific review rules were available to apply.
  • validate-links, check-markup, and check-capabilities were not executed — this session is read-only and non-interactive, so verification was done by reading the script sources (scripts/validate-links.mjs, scripts/check-capabilities.mjs) rather than running them. check-capabilities only validates capability-map URL shape and page existence, so it would not have caught either finding.

Fix these issues in Kilo Cloud


Reviewed by minimax-m3 · Input: 33.7K · Output: 3.9K · Cached: 429.5K

…capability snapshot

Copies only that record's summary and last_verified from the PR's preview
capabilities.json, so /llms.txt and the snapshot agree. A full
sync-capabilities run would also pull in unrelated developer-docs changes.
Comment thread lib/capabilities.snapshot.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant