Skip to content

force "bands" dim from args in load_stac dry run even if missing from STAC metadata - #546

Open
soxofaan wants to merge 1 commit into
masterfrom
ogd1907-load-stac-bands-in-dry-run
Open

soxofaan wants to merge 1 commit into
masterfrom
ogd1907-load-stac-bands-in-dry-run

Conversation

@soxofaan

Copy link
Copy Markdown
Member

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused fallback preserves existing behavior where applicable, includes regression coverage for both argument cases, and has no identified blocking issues.

No open issues 🎉

What changed in this PR

This PR fixes dry-run validation for load_stac when STAC metadata lacks a band dimension but the caller explicitly supplies bands, addressing issue #1907.

Changes:

  • Adds a fallback band dimension with a warning, preserving existing band dimensions.
  • Adds regression coverage for requests with and without explicit bands.
  • Documents the behavior in the changelog.
File Description
tests/​test_dry_run.py Tests band reduction when metadata lacks bands, with and without explicit band selection.
openeo_driver/​dry_run.py Adds the fallback band dimension and a metadata return type annotation.
CHANGELOG.md Documents the dry-run fallback and links the reported issue.

Review effort: Balanced

Comment thread openeo_driver/dry_run.py Outdated
@soxofaan soxofaan self-assigned this Oct 23, 2026
@soxofaan
soxofaan requested a balanced review from Copilot October 23, 2026 09:50

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

An explicit bands: null causes the new fallback to raise TypeError when metadata lacks a band dimension.

1 open issue

Review effort: Balanced

Comment thread openeo_driver/dry_run.py Outdated
@soxofaan
soxofaan force-pushed the ogd1907-load-stac-bands-in-dry-run branch from 6dc7da1 to 8bf895e Compare October 23, 2026 10:37
@soxofaan
soxofaan requested a balanced review from Copilot October 23, 2026 10:37

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused fallback has targeted regression coverage, and the only remaining feedback is a non-blocking comment typo.

1 open issue
1 resolved since last review

Review effort: Balanced

Comment thread openeo_driver/stac/datacube.py Outdated
@soxofaan
soxofaan force-pushed the ogd1907-load-stac-bands-in-dry-run branch from cdf1246 to 515a2b8 Compare October 23, 2026 15:14
@soxofaan

Copy link
Copy Markdown
Member Author

PR is ready I think, but merging is blocked by active code freeze

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Respecting cube dimension metadata can cause unexpected missing 'bands' dimension

2 participants