Repository navigation
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The focused fallback preserves existing behavior where applicable, includes regression coverage for both argument cases, and has no identified blocking issues.
No open issues 🎉
What changed in this PR
This PR fixes dry-run validation for load_stac when STAC metadata lacks a band dimension but the caller explicitly supplies bands, addressing issue #1907.
Changes:
- Adds a fallback band dimension with a warning, preserving existing band dimensions.
- Adds regression coverage for requests with and without explicit bands.
- Documents the behavior in the changelog.
| File | Description |
|---|---|
| tests/test_dry_run.py | Tests band reduction when metadata lacks bands, with and without explicit band selection. |
| openeo_driver/dry_run.py | Adds the fallback band dimension and a metadata return type annotation. |
| CHANGELOG.md | Documents the dry-run fallback and links the reported issue. |
Review effort: Balanced
soxofaan
commented
Oct 22, 2026
soxofaan
force-pushed
the
ogd1907-load-stac-bands-in-dry-run
branch
from
October 23, 2026 10:37
6dc7da1 to
8bf895e
Compare
soxofaan
force-pushed
the
ogd1907-load-stac-bands-in-dry-run
branch
from
October 23, 2026 15:14
cdf1246 to
515a2b8
Compare
Member
Author
|
PR is ready I think, but merging is blocked by active code freeze |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


fixes Open-EO/openeo-geopyspark-driver#1907