Repository navigation
Conversation
bossie
changed the title
Collaborator
Author
|
@copilot bump the alpha version and add a CHANGELOG entry. |
Co-authored-by: bossie <1032518+bossie@users.noreply.github.com>
Contributor
Bumped the alpha to |
Co-authored-by: bossie <1032518+bossie@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
Non-finite no-data values are not JSON-safe, raster extension declarations are missing, and assets without EO band metadata skip backfilling.
3 open issues
What changed in this PR
This PR exposes raster data types and no-data values in batch job results so the backend can reload its own STAC output through load_stac without guessing those values.
Changes:
- Adds asset-level metadata for STAC 1.1 and raster-band metadata backfilling for STAC 1.0.
- Updates dummy data and result-response assertions.
- Documents the change and bumps the development version to
0.142.0a4.
| File | Description |
|---|---|
tests/test_views.py |
Adds expected raster metadata to job-result responses. |
openeo_driver/dummy/dummy_backend.py |
Adds a raster data type to the sample TIFF asset. |
openeo_driver/backend_/_geopyspark.py |
Exposes and backfills raster metadata in STAC assets. |
openeo_driver/_version.py |
Bumps the development version. |
CHANGELOG.md |
Records the metadata exposure change. |
Review effort: Balanced
| "raster:bands": None if stac11 else asset_metadata.get("raster:bands"), | ||
| "file:size": asset_metadata.get("file:size"), | ||
| "alternate": asset_metadata.get("alternate"), | ||
| "nodata": asset_metadata.get("nodata") if stac11 else None, |
Comment on lines
+475
to
+477
| raster_bands = result_dict.get("raster:bands") | ||
| if raster_bands is None: | ||
| if "nodata" in asset_metadata or "data_type" in asset_metadata: |
Comment on lines
+478
to
+481
| result_dict["raster:bands"] = [ | ||
| dict_no_none(data_type=asset_metadata.get("data_type"), nodata=asset_metadata.get("nodata")) | ||
| for _ in bands | ||
| ] |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be able to properly
load_stacour own STAC 1.0 job results as described in Open-EO/openeo-geotrellis-extensions#658 (comment).Open-EO/openeo-geotrellis-extensions#863