Repository navigation
fix thread queue allocation on windows - #6132
Merged
Merged
Conversation
Contributor
Author
|
I would add the issue reproducer as a test, but it needs a machine with more cores than is available on CI, especially since the OpenBLAS default is 64 threads on windows (openblas-libs uses 24). |
Collaborator
|
Thanks - would it be possible to attach the reproducer here (though the biggest Windows machine I have myself is only 10 cores/20 threads) ? Not sure what was up with issue 1404 - I'm pretty sure the Windows support in OpenBLAS was even worse back then and compilers have also improved. Anyway the cpu mentioned there had only 6 cores/12 threads. Guess I'll finally close #1404 as not reproducible anymore (after doing one final build with Haswell rather than CooperLake target) |
Contributor
Author
|
Here is the reproducer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was worked through on MacPython/openblas-libs#284 to fix numpy/numpy#27989 and MacPython/openblas-libs#283.
On machines with many cores, there was cross-thread use of the wrong queues. This is solved here.
I used Claude code to identify and fix the problem.
Maybe related to #1404