Repository navigation
Conversation
* Don't pass `float_precision` to `read_csv` for pandas>=3.1, where
round-trip float parsing is the default
* Replace deprecated `inplace=True` by reassignment. As a consequence,
`get_{condition,observable,parameter,mapping}_df` no longer modify
DataFrames passed by the caller
* Avoid `fillna` with incompatible fill values
* Use a full-length key when adding the sum row to a MultiIndex
DataFrame in `get_data_per_observable`
* Turn all warnings, including `DeprecationWarning`s, into errors in
tests. The pandas deprecation warnings derive from
`DeprecationWarning`, which was ignored so far
* Require pandas>=2.3 in accordance with NEP 29
Closes PEtab-dev#570
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #571 +/- ##
==========================================
+ Coverage 78.85% 78.87% +0.02%
==========================================
Files 69 69
Lines 8043 8051 +8
Branches 1445 1445
==========================================
+ Hits 6342 6350 +8
Misses 1214 1214
Partials 487 487 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dweindl
marked this pull request as ready for review
October 22, 2026 14:45
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the deprecation warnings raised with pandas 3.1.0 and raises the minimum pandas version.
float_precisiontoread_csvfor pandas>=3.1, where round-trip float parsing is the default (kept for older pandas).inplace=Trueby reassignment. As a consequence,get_{condition,observable,parameter,mapping}_dfno longer modify DataFrames passed by the caller.fillnawith incompatible fill values.get_data_per_observable.DeprecationWarnings, into errors in tests. The pandas deprecation warnings derive fromDeprecationWarning, which was ignored so far, which is why these went unnoticed. The SWIG-relatedDeprecationWarningfrom python-libcombine on Python 3.14 remains ignored, since raising it during module initialization segfaults.pandas>=2.3in accordance with NEP 29 (2.3, 3.0, 3.1 released within the past 24 months).Tests pass with pandas 3.1.0 and 2.3.3.
Closes #570
🤖 Generated with Claude Code