Skip to content

[Do Not Merge] Remove pre-release startup warnings #6023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
rbev wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[Do Not Merge] Remove pre-release startup warnings #6023

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/ServiceControl.Persistence.EFCore.PostgreSql/PostgreSqlPersistenceConfiguration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,11 @@
namespace ServiceControl.Persistence.EFCore.PostgreSql;

using Microsoft.Extensions.Logging;
using ServiceControl.Infrastructure;
using ServiceControl.Persistence.EFCore.Abstractions;

class PostgreSqlPersistenceConfiguration : EFPersistenceConfigurationBase
{
public override IPersistence Create(PersistenceSettings settings)
{
// Temporary until the persister is fully implemented
LoggerUtil.CreateStaticLogger<PostgreSqlPersistenceConfiguration>()
.LogError("The PostgreSQL persistence is still under development and is not ready for use");

return new PostgreSqlPersistence((PostgreSqlPersisterSettings)settings);
}

Expand Down
6 changes: 0 additions & 6 deletions src/ServiceControl.Persistence.EFCore.SqlServer/SqlServerPersistenceConfiguration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,11 @@
namespace ServiceControl.Persistence.EFCore.SqlServer;

using Microsoft.Extensions.Logging;
using ServiceControl.Infrastructure;
using ServiceControl.Persistence.EFCore.Abstractions;

class SqlServerPersistenceConfiguration : EFPersistenceConfigurationBase
{
public override IPersistence Create(PersistenceSettings settings)
{
// Temporary until the persister is fully implemented
LoggerUtil.CreateStaticLogger<SqlServerPersistenceConfiguration>()
.LogError("The SQL Server persistence is still under development and is not ready for use");

var sqlSettings = (SqlServerPersisterSettings)settings;

return new SqlServerPersistence(sqlSettings);
Expand Down
Loading