Repository navigation
Conversation
saadndm
force-pushed
the
fix/search-focus
branch
from
October 19, 2026 01:41
db6e4f0 to
fdef0a4
Compare
lunaynx
force-pushed
the
fix/search-focus
branch
from
October 19, 2026 12:48
fdef0a4 to
044d55b
Compare
lunaynx
requested changes
Oct 19, 2026
saadndm
force-pushed
the
fix/search-focus
branch
from
October 21, 2026 00:06
345cbe8 to
03cb0bd
Compare
saadndm
force-pushed
the
fix/search-focus
branch
from
October 21, 2026 23:39
03cb0bd to
05fd0d8
Compare
lunaynx
requested changes
Oct 22, 2026
Comment on lines
+184
to
+185
| awaitFirstDown(requireUnconsumed = false, pass = PointerEventPass.Initial) | ||
| if (focused) focusManager.clearFocus() |
Contributor
There was a problem hiding this comment.
🟡 [P2] End the active range edit before stepping either spinner
When editing one range endpoint and clicking the other spinner’s arrow,
focusedis false here, so the active editor never loses focus andRangeSpinners.onEditEnddoes not normalize the pair before stepping. Reproduced with an initial range of 10–20: type 30 into the left field, then click the right up-arrow. This patch stores 21–30 and displays 30–21, whereas the base correctly produces 20–31. End the active range edit before applying the arrow step, even when the focused field belongs to the other spinner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1197