Repository navigation
Conversation
Member
|
Thanks, can you also fix the notification bell icon here: It can just be: Box {
Icon(iconName, color, modifier) |
Author
|
With pleasure! Ill sort it out straight away |
Author
Author
|
Closes #1067 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Notification toasts always used the default icons, even with the Minecraft theme. The notifications center in the main menu already showed the Minecraft icons, because it goes through the themed
Iconcomponent andMinecraftIconOverrides.The toasts are drawn by the
notificationsmodule, which doesn't know about the UI themes. Instead, the theme is pushed to it bysyncNotificationTheme, which already passed the colours, fonts and corner radii but not the icons. SoSvgRasterizeralways loaded/assets/oneconfig/ico/<name>.svg.This PR:
iconFolderproperty toNotificationTheme, set bysyncNotificationThemeto"minecraft"when a Minecraft theme is active and tonullotherwiseSvgRasterizer.getlook inico/<folder>/first, falling back to the default icon when there's no overrideToastIconThe Minecraft versions of all four type icons (
info,check-circle,alert-circle,refresh) already exist, so no new assets are needed.The setter is a separate
useIconFolderfunction rather than a new parameter onset(...), so the existingsetsignature stays binary compatible. The API dump only has additions.Tested on
26.3-fabricwith/testmod notifyTestand/testmod notifyProgress, in Minecraft Dark and PolyGlass Dark.Related Issue(s)
Closes #1066
Checklist