Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the HUD studio, pressing any key while a locked HUD was selected showed the "HUD element locked" toast. The locked check in the key handler was running before the arrow key filter, so every key reached it, and it was also consuming those keys.
I removed that early check and made the existing check after the arrow key
whencover every selected HUD (selectedHuds.any { it.locked }) instead of only the primary one. So now:I also removed the
primaryHud()lookup since it wasn't used anymore.selectedHudsis already checked to be non-empty right before, so it couldn't be null there anyway.Tested on 26.3-fabric : letters, Shift and Space on a locked HUD, arrows on a locked HUD, arrows on an unlocked HUD, and a mixed selection with one locked and one unlocked HUD.
Related Issue(s)
Closes #1138
Checklist