Repository navigation
Conversation
- eToro in the brokerage and data provider choices with the api key, user key and real or demo account options
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds eToro to the live deployment and data download commands. The change is the regenerated
README.md, because the module itself is described inmodules-1.14.json, which this repository does not track; the module entry is sent to the team separately.The module is a brokerage, a data queue handler, a history provider and a data downloader: the plugin (Lean.Brokerages.Etoro, PR #5) streams instrument rates as ticks and reads quote bars from the eToro candles. It trades equities, crypto and currency pairs with market orders. It asks for three values:
The user key is a password prompt. The environment choice sets the
etoro-demo-environmentflag of the plugin, the way the Alpaca module setsalpaca-paper-tradingfrom its environment choice. The API address is an internal input, so nobody is asked for it. The specifications point atetoro.jsonin the plugin repository. Product id 465.Related PR(s)
Lean core: QuantConnect/Lean#9886
Related Issue
N/A
Motivation and Context
Without this,
lean live deploy,lean cloud live deployandlean data downloaddo not offer eToro, so the plugin cannot be used from the CLI.Requires Documentation Change
The brokerage needs its own page under the live trading brokerages section, like the other brokerages have.
How Has This Been Tested?
modules-1.14.json.get_configs_for_options("live-cli")andget_configs_for_options("live-cloud")both return the three eToro options:etoro-api-key,etoro-user-key,etoro-environment.README.mdwas regenerated withscripts/readme.py. The change is 39 added lines and 9 replaced lines, all of them eToro: the brokerage and data provider choices of six commands, and the three options under each.Types of changes
Checklist:
bug-<issue#>-<description>orfeature-<issue#>-<description>