Repository navigation
characterization tests and atime overhead guard for [ modularization - #7931
Open
ben-schwen wants to merge 1 commit into
Open
ben-schwen wants to merge 1 commit into
ben-schwen wants to merge 1 commit into
Conversation
ben-schwen
requested review from
Anirban166,
MichaelChirico and
tdhock
as code owners
October 21, 2026 09:42
…852) Pins down behaviour that the upcoming refactor of [.data.table could silently change: resolution of i/j/by/on/.SDcols/env= in the calling frame (incl. nested closures), .N shadowing in the caller, early returns, missing() semantics (including arguments substituted to the empty symbol via env=), forms of i, forms of j with with=FALSE and also forms of by. joins combined with by=.EACHI/:=/roll, and := forms. Also covers some previously uncovered lines (mult='error' without duplicates, datatable.join.many=FALSE, := on key column). Adds an atime test measuring the per-call overhead of [.
ben-schwen
force-pushed
the
brk/a1_tests
branch
from
October 21, 2026 10:20
1856d0e to
a2e6a4a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7931 +/- ##
=======================================
Coverage 99.08% 99.09%
=======================================
Files 88 88
Lines 17420 17420
=======================================
+ Hits 17261 17262 +1
+ Misses 159 158 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ben-schwen
added this pull request to stack #7933
October 21, 2026 10:29
Member
|
Aside -- are you using |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #852
This PR is the starting point of modularizing [.
I will build it as stack on top of each other. I moved the tests to a new script since [ is such a central piece that I thought it deserves its own place. Moreover, it gives us the chance to set them as optional.