Repository navigation
docs(compass): design comms file sharing (RIG-2669) - #25
Open
rigel-mintaka wants to merge 1 commit into
Open
rigel-mintaka wants to merge 1 commit into
rigel-mintaka wants to merge 1 commit into
Conversation
Moved from RigelBuild/compass#2153 under the design-records-to-docs-repo directive. Co-authored-by: Matt Wilkinson <matt@rigel.build>
rigel-mintaka
force-pushed
the
compass-comms/rig-2669-file-sharing-design
branch
from
October 18, 2026 14:52
84fa072 to
72437df
Compare
|
Rigel public design docs preview: https://compass-comms-rig-2669-file.docs-2ui.pages.dev Deployed from |
rigel-mintaka
marked this pull request as ready for review
October 18, 2026 14:59
Contributor
Author
|
Head note at
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved
docs/designs/compass/.mainblob URLs.Summary
Design record for RIG-2669: file sharing on the comms surface. Agents and the operator can attach a file to a channel, topic or DM message, and anyone who can read that message can read the file. Agents get attach and read tools; the operator downloads from the UI and the CLI.
Record:
docs/designs/agent/compass-comms-file-sharing/design.md. Ledger rows: DL-480 to DL-485, allActive (proposed, pending Matt, 2026-10-11).Decisions (proposed)
ObjectStoreunderblobs/<sha256>, as session blobs do (DL-426). A new tenant-RLScomms_attachmentstable indexes them.UploadAttachment/GetAttachmentRPCs on CommsService; newMessageBlockarm 4. Upload first, then a post binds the attachment to one message. Agent call arms 16 and 17.IsTopicChannelMember, the probe that already gatesMessagePosted. The uploader can also read it until it is posted. Every refusal is NotFound.comms_attach_fileandcomms_read_file.application/octet-stream);compass message attach/get.ObjectStore(--object-dir, default<StateDir>/objects) so local stacks have storage (OQ-1).Open questions for Matt
OQ-1 (load-bearing: a directory-backed object store for local stacks, recommended) is with Matt in RIG-5148. OQ-2 to OQ-4 are deferrals: retention and GC as one follow-up, no UI upload, no files over 15 MiB. The Plan builds each recommendation and lists the delta for the other options.
Review
An adversarial design critic and three review-correctness rounds; every finding is folded in. Review at head
4a65014d: 0 high, 0 medium, 0 low, 0 nit (see the PR comment).Spec-impact: none
Ledger-impact: DL-480..485 added (proposed)
Refs RIG-2669
Co-authored-by: Matt Wilkinson matt@rigel.build