Repository navigation
docs(compass): design collapsing the channel-group tree into the agent tree (RIG-2684) - #26
Open
rigel-mintaka wants to merge 2 commits into
Open
rigel-mintaka wants to merge 2 commits into
rigel-mintaka wants to merge 2 commits into
Conversation
…t tree (RIG-2684) Moved from RigelBuild/compass#2170 under the design-records-to-docs-repo directive. Co-authored-by: Matt Wilkinson <matt@rigel.build>
rigel-mintaka
force-pushed
the
compass-comms/rig-2684-collapse-group-tree-design
branch
from
October 18, 2026 14:52
447d6ea to
1e76f4b
Compare
…ollapse (RIG-2684) These four decisions now live in this repo, so the status edits the record deferred at the move apply here. Co-authored-by: Matt Wilkinson <matt@rigel.build>
|
Rigel public design docs preview: https://compass-comms-rig-2684-colla.docs-2ui.pages.dev Deployed from |
rigel-mintaka
marked this pull request as ready for review
October 18, 2026 14:59
Contributor
Author
|
Head note at
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved
docs/designs/compass/.mainblob URLs.Summary
Design record for RIG-2684: collapse the channel-group tree into the agent tree, so Compass has one hierarchy. It builds on
docs/designs/ui/compass-channels-in-agent-tree(DL-344/345/397), which moved channels into the agent tree but keptChannelGroupas server machinery. This record removes what is left.Record:
docs/designs/agent/compass-collapse-channel-group-tree/design.md. New rows DL-487 to DL-490, allActive (proposed, pending Matt, 2026-10-11).Decisions (proposed)
channel_groups,channels.group_id, the MIN-over-ancestry lattice,channels_group_name_keyandchannels_group_xor_agent. DL-345's owner-set grant is the only tree visibility class.channels.system_namespace+namespace_owner_id, unique per owner.ReparentChannelrefuses system channels.channels.sharedon root channels (channels_shared_root_only), keeping DL-397's "never in a tree".comms_create_channelgainsparent?/shared?;comms_create_channel_groupgoes.reserved(DL-186);sharedat fresh numbersChannel.shared = 13,CreateChannelRequest.shared = 8. No field number is reused at a new wire type.0001_init.sqlin place per the pre-wipe policy (RIG-4927). A deployed dev DB needs a recreate; no backfill.Supersession
channels_group_xor_agentCHECK clause (→ DL-488, replaced bychannels_shared_root_only). Clause-level statuses follow the DL-097/DL-208 precedent.Open questions for Matt
OQ1–OQ5 are load-bearing and filed as RIG-5154. The Plan builds each recommendation.
Review
An adversarial design critic and two review-correctness rounds; every finding is folded in. Review at head
526d84b3: 0 high, 0 medium, 0 low, 0 nit (see the PR comment).Spec-impact: none
Ledger-impact: DL-487..490 added (proposed); DL-344 and DL-397 clause-level, DL-295 and DL-395 flipped to superseded (proposed)
Refs RIG-2684
Co-authored-by: Matt Wilkinson matt@rigel.build