Repository navigation
feat(ledger): holon-jsonld-lineage on download_report_bundle - #284
Merged
Merged
Conversation
The lineage holon (the holon with its #lineage graph: the ledger lines, entries and events behind every frozen figure) had no short alias, so a caller had to pass the GraphQL enum name, and a download whose response named no file landed as .tavi.json. "holon-jsonld-lineage" now maps to HOLON_JSONLD_LINEAGE, a nameless download lands as .lineage.holon.jsonld, and the docstring lists the format. Claude-Session: https://claude.ai/code/session_015PxYaVzrbraKFeRALM7rXp
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
download_report_bundlegains the short alias"holon-jsonld-lineage"for the lineage holon: the holon with its#lineagegraph, the ledger lines, entries and events behind every frozen figure. Until now a caller had to pass the GraphQL enum name, which the robosystems demos do (robosystems #1933), and a download whose response named no file landed with a.tavi.jsonextension.Changes
robosystems_client/clients/ledger_client.py:"holon-jsonld-lineage"→HOLON_JSONLD_LINEAGEin the format aliases; a nameless lineage download lands as.lineage.holon.jsonld; the docstring lists the format and its enum name.tests/test_ledger_client.py: the alias sends the enum, and the fallback filename takes the lineage extension.Compatibility
Additive, generated tier untouched. A client minor; the enum has been in the generated schema since the lineage format shipped. Pairs with robosystems-typescript-client's docs change for the same format.
Testing
just test-all: 733 passed, 17 skipped; ruff, format and basedpyright clean.🤖 Generated with Claude Code
https://claude.ai/code/session_015PxYaVzrbraKFeRALM7rXp