Skip to content

[WIP] Update spirt to 0.5.0. - #684

Draft
eddyb wants to merge 8 commits into
mainfrom
eddyb/spirt-0.5.0
Draft

eddyb wants to merge 8 commits into
mainfrom
eddyb/spirt-0.5.0

Conversation

@eddyb

@eddyb eddyb commented Oct 15, 2026

Copy link
Copy Markdown
Member

Will stay as draft until spirt 0.5.0 is released, containing at least:


This came about because of OpExecutionModeId/FPFastMathDefault, wanted by:

FPFastMathDefault takes:

  • a type ID operand
    • this is itself unusual (as in, types as operands is rare), I've handled it via a Type-in-Const embedding that other extensions also ended up needing independently (e.g. OpUntypedPtrAccessChainKHR)
  • a constant integer ID operand
    • not a literal (for specialization constants, maybe? the spec does mix IDs and literals elsewhere)

And any IDs being involved meant spirt::Attr::SpvAnnotation has to grow an extra field (which is even worse than just some Consts, because of how AttrSet relies on Attr: Ord etc.).

Hopefully the solution will cover anything else Rust-GPU may need for the next little while.

@eddyb
eddyb added this pull request to stack #685 October 15, 2026 23:08
Base automatically changed from eddyb/fmt-args-minor-untangle to main October 16, 2026 11:47
@eddyb
eddyb force-pushed the eddyb/spirt-0.5.0 branch from 0cb1693 to 6537c00 Compare October 16, 2026 11:47
@jlogan03

Copy link
Copy Markdown
  (cc @jlogan03, you might be able to test by rebasing on top of this branch)

Thanks! I rebased on top of this branch and it works 🎉

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants